From: Richard Henderson <richard.henderson@linaro.org>
To: Deepak Gupta <debug@rivosinc.com>,
qemu-riscv@nongnu.org, qemu-devel@nongnu.org
Cc: palmer@dabbelt.com, Alistair.Francis@wdc.com, bmeng.cn@gmail.com,
liwei1518@gmail.com, dbarboza@ventanamicro.com,
zhiwei_liu@linux.alibaba.com, jim.shu@sifive.com,
andy.chiu@sifive.com, kito.cheng@sifive.com
Subject: Re: [PATCH v8 04/17] target/riscv: additional code information for sw check
Date: Mon, 26 Aug 2024 09:59:55 +1000 [thread overview]
Message-ID: <10bf932c-ec07-4f2d-ae11-93fdd2bf84ee@linaro.org> (raw)
In-Reply-To: <20240823190140.4156920-5-debug@rivosinc.com>
On 8/24/24 05:01, Deepak Gupta wrote:
> diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
> index 12484ca7d2..9f08a67a9e 100644
> --- a/target/riscv/cpu_helper.c
> +++ b/target/riscv/cpu_helper.c
> @@ -1761,6 +1761,8 @@ void riscv_cpu_do_interrupt(CPUState *cs)
> cs->watchpoint_hit = NULL;
> }
> break;
> + case RISCV_EXCP_SW_CHECK:
> + tval = env->sw_check_code;
> default:
Missing break.
This should have warned about fall through...
r~
next prev parent reply other threads:[~2024-08-26 0:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 19:01 [PATCH v8 00/17] riscv support for control flow integrity extensions Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 01/17] target/riscv: Add zicfilp extension Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 02/17] target/riscv: Introduce elp state and enabling controls for zicfilp Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 03/17] target/riscv: save and restore elp state on priv transitions Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 04/17] target/riscv: additional code information for sw check Deepak Gupta
2024-08-25 23:59 ` Richard Henderson [this message]
2024-08-26 15:17 ` Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 05/17] target/riscv: tracking indirect branches (fcfi) for zicfilp Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 06/17] target/riscv: zicfilp `lpad` impl and branch tracking Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 07/17] disas/riscv: enable `lpad` disassembly Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 08/17] target/riscv: Add zicfiss extension Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 09/17] target/riscv: introduce ssp and enabling controls for zicfiss Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 10/17] target/riscv: tb flag for shadow stack instructions Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 11/17] target/riscv: mmu changes for zicfiss shadow stack protection Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 12/17] target/riscv: AMO operations always raise store/AMO fault Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 13/17] target/riscv: update `decode_save_opc` to store extra word2 Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 14/17] target/riscv: implement zicfiss instructions Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 15/17] target/riscv: compressed encodings for sspush and sspopchk Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 16/17] disas/riscv: enable disassembly for zicfiss instructions Deepak Gupta
2024-08-23 19:01 ` [PATCH v8 17/17] disas/riscv: enable disassembly for compressed sspush/sspopchk Deepak Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10bf932c-ec07-4f2d-ae11-93fdd2bf84ee@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=andy.chiu@sifive.com \
--cc=bmeng.cn@gmail.com \
--cc=dbarboza@ventanamicro.com \
--cc=debug@rivosinc.com \
--cc=jim.shu@sifive.com \
--cc=kito.cheng@sifive.com \
--cc=liwei1518@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).