From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Foley <pefoley@google.com>, qemu-devel@nongnu.org
Cc: Christian Schoenebeck <qemu_oss@crudebyte.com>,
Greg Kurz <groug@kaod.org>,
nabihestefan@google.com
Subject: Re: [PATCH] 9pfs: Include glib.h
Date: Fri, 5 Sep 2025 09:27:47 +0200 [thread overview]
Message-ID: <10c9a015-16a1-4f5a-a0fc-85d01cef8651@redhat.com> (raw)
In-Reply-To: <20250904-9p-v1-1-e634cb374c80@google.com>
On 9/4/25 16:30, Peter Foley wrote:
> gstrfuncs.h is not intended to be included directly.
Indeed -- it works only because qemu/osdep.h actually already includes
glib.h. So the line can be removed altogether.
Thanks for looking at these papercuts and bringing attention to the QEMU
upstream developers.
Paolo
> Signed-off-by: Peter Foley <pefoley@google.com>
> ---
> hw/9pfs/9p-util-generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/9pfs/9p-util-generic.c b/hw/9pfs/9p-util-generic.c
> index 4c1e9c887d00c44bc073bec00c07ed09d3868bf5..93c38e40f693a945f979ca89555cd9b1ea3175d6 100644
> --- a/hw/9pfs/9p-util-generic.c
> +++ b/hw/9pfs/9p-util-generic.c
> @@ -2,7 +2,7 @@
>
> #include "qemu/osdep.h"
> #include "9p-util.h"
> -#include <glib/gstrfuncs.h>
> +#include <glib.h>
>
> char *qemu_open_flags_tostr(int flags)
> {
>
> ---
> base-commit: baa79455fa92984ff0f4b9ae94bed66823177a27
> change-id: 20250904-9p-11c0405ae7c5
>
> Best regards,
prev parent reply other threads:[~2025-09-05 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 14:30 [PATCH] 9pfs: Include glib.h Peter Foley
2025-09-05 7:27 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10c9a015-16a1-4f5a-a0fc-85d01cef8651@redhat.com \
--to=pbonzini@redhat.com \
--cc=groug@kaod.org \
--cc=nabihestefan@google.com \
--cc=pefoley@google.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).