* [PATCH] pc: comment stule fixup
@ 2020-11-02 10:09 Michael S. Tsirkin
2020-11-02 10:25 ` Philippe Mathieu-Daudé
2020-11-02 12:00 ` Markus Armbruster
0 siblings, 2 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2020-11-02 10:09 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Eduardo Habkost, Richard Henderson
Fix up checkpatch comment style warnings.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/i386/pc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 416fb0e0f6..5872ae6095 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1150,9 +1150,9 @@ void pc_basic_device_init(struct PCMachineState *pcms,
exit(1);
}
/* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7
- * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
- * IRQ8 and IRQ2.
- */
+ * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
+ * IRQ8 and IRQ2.
+ */
uint8_t compat = object_property_get_uint(OBJECT(hpet),
HPET_INTCAP, NULL);
if (!compat) {
--
MST
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pc: comment stule fixup
2020-11-02 10:09 [PATCH] pc: comment stule fixup Michael S. Tsirkin
@ 2020-11-02 10:25 ` Philippe Mathieu-Daudé
2020-11-02 12:00 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-02 10:25 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: Paolo Bonzini, Eduardo Habkost, Richard Henderson
On 11/2/20 11:09 AM, Michael S. Tsirkin wrote:
> Fix up checkpatch comment style warnings.
Typo stule -> style in subject ;)
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/i386/pc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 416fb0e0f6..5872ae6095 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1150,9 +1150,9 @@ void pc_basic_device_init(struct PCMachineState *pcms,
> exit(1);
> }
> /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7
Since it needs a respin, maybe convert the 1st line too?
> - * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
> - * IRQ8 and IRQ2.
> - */
> + * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
> + * IRQ8 and IRQ2.
> + */
> uint8_t compat = object_property_get_uint(OBJECT(hpet),
> HPET_INTCAP, NULL);
> if (!compat) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pc: comment stule fixup
2020-11-02 10:09 [PATCH] pc: comment stule fixup Michael S. Tsirkin
2020-11-02 10:25 ` Philippe Mathieu-Daudé
@ 2020-11-02 12:00 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2020-11-02 12:00 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Paolo Bonzini, Richard Henderson, qemu-devel, Eduardo Habkost
"Michael S. Tsirkin" <mst@redhat.com> writes:
> Fix up checkpatch comment style warnings.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/i386/pc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 416fb0e0f6..5872ae6095 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1150,9 +1150,9 @@ void pc_basic_device_init(struct PCMachineState *pcms,
> exit(1);
> }
> /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7
> - * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
> - * IRQ8 and IRQ2.
> - */
> + * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
> + * IRQ8 and IRQ2.
> + */
> uint8_t compat = object_property_get_uint(OBJECT(hpet),
> HPET_INTCAP, NULL);
> if (!compat) {
Since you're touching this already...
CODING_STYLE.rst:
Multiline comment blocks should have a row of stars on the left,
and the initial /``*`` and terminating ``*``/ both on their own lines:
.. code-block:: c
/*
* like
* this
*/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-02 12:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-02 10:09 [PATCH] pc: comment stule fixup Michael S. Tsirkin
2020-11-02 10:25 ` Philippe Mathieu-Daudé
2020-11-02 12:00 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).