From: Richard Henderson <richard.henderson@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] authz: optimize linking of objects for authorization services
Date: Tue, 21 May 2019 10:39:12 -0400 [thread overview]
Message-ID: <10d9f115-337e-f14e-c79a-93d98d72248b@linaro.org> (raw)
In-Reply-To: <20190521093227.4661-1-berrange@redhat.com>
On 5/21/19 5:32 AM, Daniel P. Berrangé wrote:
> The core authorization API is a dependancy of the crypto code for the
> TLS servers. The TLS server code is pulled into anything which links
> to the crypto objects, which is every QEMU tool. This in turns means
> that every tool ended up linking to the authz code, which in turn
> pulls in the PAM library dep.
>
> This splits the authz code so that everything links to the base object
> which defines the API. Only the system emulators and qemu-nbd link to
> the object classes providing the implementations of the authz object
> API. This has the effect of removing the PAM library dep from qemu-img,
> qemu-io and other helper tools.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> Makefile | 5 +++--
> Makefile.objs | 1 +
> Makefile.target | 3 ++-
> authz/Makefile.objs | 9 +++++----
> 4 files changed, 11 insertions(+), 7 deletions(-)
No changes to tests/? Surely that means some tests no longer link?
r~
next prev parent reply other threads:[~2019-05-21 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 9:32 [Qemu-devel] [PATCH] authz: optimize linking of objects for authorization services Daniel P. Berrangé
2019-05-21 9:40 ` no-reply
2019-05-21 14:39 ` Richard Henderson [this message]
2019-05-21 14:40 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10d9f115-337e-f14e-c79a-93d98d72248b@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).