From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B892DC35250 for ; Sat, 8 Feb 2020 08:31:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CE862051A for ; Sat, 8 Feb 2020 08:31:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xh2E4Oh/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CE862051A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0LWI-0005zb-9t for qemu-devel@archiver.kernel.org; Sat, 08 Feb 2020 03:31:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51849) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0LUy-0004Zm-Vh for qemu-devel@nongnu.org; Sat, 08 Feb 2020 03:29:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j0LUv-0003g9-3p for qemu-devel@nongnu.org; Sat, 08 Feb 2020 03:29:56 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:37561) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j0LUu-0003fa-Sq for qemu-devel@nongnu.org; Sat, 08 Feb 2020 03:29:53 -0500 Received: by mail-wm1-x342.google.com with SMTP id f129so5189893wmf.2 for ; Sat, 08 Feb 2020 00:29:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+nCdLCaBDmqnEn7ZYYF27GMv/dmswyV9SbuqtuhOtZY=; b=xh2E4Oh/TwJWpOfCylXxxKiGtXbYO9J713SXIVWeRAfG517ltayIDb6kYgrkgWxMnM EmMfro+y0U+f5JvUixJ/UEoQi1gP+YjyEfonRoFzrMEuiJzOqV9bWlsMOdtd187PdNHr S1frm5ddoC7PTe69TRHDooQTKFQDJokuAseYu+hxi44ivf3oWlJdrijV6qhyXoD5uydT 2k7HkcBYKugmLn1i7aIrZ6nk4fmpaQxQfQBgtpQkK07oIc5z92KvZ0plXOiGbqwWFcNt ent7d9GKB5JagHI4mS8dobUgu+wTg3hjOYigEysmwvMxZXk6fPY0ElPWVMlvzwyPtDbN OEBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+nCdLCaBDmqnEn7ZYYF27GMv/dmswyV9SbuqtuhOtZY=; b=seeVIra0ytQwRJ9r4gQS1INnv4s7mp6odZGHd6WmfkDwlN5Nv86nWssoH+tnYnPzTl ApiVH/9g27wRuH+QjDPtOCAIfW13CBsZiJ0bKAizp7MMPEAlcMT8FxZew/yuY7XjeCC9 ATS2As8nIRipPW+vGhgCKujGx+8hk6qJF1Z11sB179OMmUyi905TcwfJkHd/GxhNC++N Uqg1rk0gQXk6uO4b5nTAakNAnD71i/x41EmvwL9cg/u+TaM19cyCwnySX0WuIA8xr7Hb nwVa6sLzN+FtZpd41yzlIPfl3pWFy/JxGVGa20zG1bcUQHtUnOPII2wRolj+0qDlUfAH YqwA== X-Gm-Message-State: APjAAAUu8vmcmgww+c1TxqaXjb9GItASBKG8jhvt0ZPPPYwy0VaJwAIQ 72TP3ikt/6fO9YkPoKQsGRjKpQ== X-Google-Smtp-Source: APXvYqxik45zCtoUrqPKxGHbNsZ3Ml7YOccGUrPzg7g7sTTYZKs/VP0DgwnGoGA1ZD9AOIabpRmgQw== X-Received: by 2002:a05:600c:2207:: with SMTP id z7mr3335936wml.138.1581150591874; Sat, 08 Feb 2020 00:29:51 -0800 (PST) Received: from [10.43.13.93] ([135.196.99.211]) by smtp.gmail.com with ESMTPSA id v15sm139224wrf.7.2020.02.08.00.29.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Feb 2020 00:29:51 -0800 (PST) Subject: Re: [PATCH v3 09/20] target/arm: Tidy msr_mask To: Peter Maydell References: <20200203144716.32204-1-richard.henderson@linaro.org> <20200203144716.32204-10-richard.henderson@linaro.org> From: Richard Henderson Message-ID: <10deb047-06b8-1bae-bd11-b0df7cfca846@linaro.org> Date: Sat, 8 Feb 2020 08:29:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/7/20 5:40 PM, Peter Maydell wrote: > On Mon, 3 Feb 2020 at 14:47, Richard Henderson > wrote: >> >> The CPSR_USER mask for IS_USER already avoids all of the RES0 >> bits as per aarch32_cpsr_valid_mask. Fix up the formatting. > > CPSR_USER includes CPSR_Q and CPSR_GE, which might be RES0 > depending on feature bit settings. Oops, yes. > Diff made a bit of a mess of this patch -- I think it would > be easier to understand if the reformatting to add {} was > separate from the code change. Because of the above, I'll probably drop all of this except for the formatting fix. r~