From: Eric Blake <eblake@redhat.com>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] hw/block: Introduce rotational qdev property
Date: Sat, 6 May 2017 12:11:58 -0500 [thread overview]
Message-ID: <10e6a024-f9d1-b33a-9181-3b896dcccd4d@redhat.com> (raw)
In-Reply-To: <20170506124314.23354-1-aurelien@aurel32.net>
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
On 05/06/2017 07:43 AM, Aurelien Jarno wrote:
> The Linux kernel uses different I/O scheduler depending if the block
> device is a rotational device or not. Also it uses rotational devices
> to add entropy to the random pool.
>
> This patch add a rotational qdev property so that the block device can
> be configured as a rotational device or a non-rotational device. Default
> to true to not change the default behavior.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> blockdev.c | 4 ++++
> include/hw/block/block.h | 4 +++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
Please remember to send a 0/3 cover letter when sending a series (you
can use 'git config format.coverletter auto' to make it easier).
The NBD server has the ability to expose to a client whether a given
exported volume is rotational or not; so there may be some additional
integration you should perform to make nbd-server properly export this
new property.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-05-06 17:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 12:43 [Qemu-devel] [PATCH 1/3] hw/block: Introduce rotational qdev property Aurelien Jarno
2017-05-06 12:43 ` [Qemu-devel] [PATCH 2/3] scsi-disk: export " Aurelien Jarno
2017-05-06 16:11 ` Philippe Mathieu-Daudé
2017-05-06 12:43 ` [Qemu-devel] [PATCH 3/3] ide: " Aurelien Jarno
2017-05-06 16:11 ` Philippe Mathieu-Daudé
2017-05-08 14:50 ` John Snow
2017-05-06 16:11 ` [Qemu-devel] [PATCH 1/3] hw/block: Introduce " Philippe Mathieu-Daudé
2017-05-06 17:11 ` Eric Blake [this message]
2017-05-08 17:22 ` Stefan Hajnoczi
2017-05-09 10:12 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10e6a024-f9d1-b33a-9181-3b896dcccd4d@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).