qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: 8.1-rc0 testfloat fails to compile
Date: Fri, 21 Jul 2023 09:18:08 +0200	[thread overview]
Message-ID: <10e95d52-109a-d683-a9ea-2ab9b52e795d@redhat.com> (raw)
In-Reply-To: <20230721090359.1b9797cd.olaf@aepfle.de>

On 21/07/2023 09.03, Olaf Hering wrote:
> Fri, 21 Jul 2023 08:54:21 +0200 Thomas Huth <thuth@redhat.com>:
> 
>> Which compiler version is causing trouble for you?
> 
> Right now it is gcc 13, hopefully every compiler will error out with -Werror=return-type.

I don't think this will happen - otherwise we would have seen this already. 
It rather looks like your compiler version is missing something here - have 
a look at the affected function:

static float64_t f64Random( void )
{

     switch ( random_ui8() & 7 ) {
      case 0:
      case 1:
      case 2:
         return f64RandomQOutP3();
      case 3:
         return f64RandomQOutPInf();
      case 4:
      case 5:
      case 6:
         return f64RandomQInfP3();
      case 7:
         return f64RandomQInfPInf();
     }

}

The argument in the switch statement is limited with "& 7" to the range of 0 
... 7 , so there is no way the control flow can really reach the bottom of 
the function. I wonder why your GCC 13 gets that wrong, all other versions 
seem to be fine.
Or are you compiling with -O0 or something similar?

> I think it makes sense to replace Leap with Tumbleweed. 

IIRC we wanted to avoid rolling releases in the CI since this would rather 
force us to deal with distro bugs on a regular basis instead of focusing on 
bugs in QEMU.

  Thomas




  reply	other threads:[~2023-07-21  7:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 20:47 8.1-rc0 testfloat fails to compile Olaf Hering
2023-07-21  6:54 ` Thomas Huth
2023-07-21  7:03   ` Olaf Hering
2023-07-21  7:18     ` Thomas Huth [this message]
2023-07-21  7:35       ` Olaf Hering
2023-07-21  7:53         ` Thomas Huth
2023-07-21  8:04           ` Olaf Hering
2023-07-22 12:49   ` Richard Henderson
2023-07-24 12:37     ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10e95d52-109a-d683-a9ea-2ab9b52e795d@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=olaf@aepfle.de \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).