Re: [Qemu-devel] [PATCH v2 03/10] hw/pci-bridge: Use the QOM BUS() macro to access BusState.qbus

[Marcel Apfelbaum <marcel.apfelbaum@gmail.com>]

On 5/28/19 7:40 PM, Philippe Mathieu-Daudé wrote:
> Rather than looking inside the definition of a BusState with "s->bus.qbus",
> use the QOM prefered style: "BUS(&s->bus)".
>
> This patch was generated using the following Coccinelle script:
>
>      // Use BUS() macros to access BusState.qbus
>      @use_bus_macro_to_access_qbus@
>      expression obj;
>      identifier bus;
>      @@
>      -&obj->bus.qbus
>      +BUS(&obj->bus)
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   hw/pci/pci_bridge.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
> index c6d9ded320..8d954885c0 100644
> --- a/hw/pci/pci_bridge.c
> +++ b/hw/pci/pci_bridge.c
> @@ -273,7 +273,7 @@ void pci_bridge_write_config(PCIDevice *d,
>       newctl = pci_get_word(d->config + PCI_BRIDGE_CONTROL);
>       if (~oldctl & newctl & PCI_BRIDGE_CTL_BUS_RESET) {
>           /* Trigger hot reset on 0->1 transition. */
> -        qbus_reset_all(&s->sec_bus.qbus);
> +        qbus_reset_all(BUS(&s->sec_bus));
>       }
>   }
>   

Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>

Thanks,
Marcel