[PATCH 0/2] tests: Drop mentions of SoftMMU

[PATCH 0/2] tests: Drop mentions of SoftMMU

[Philippe Mathieu-Daudé]

We want to clarify when code depends on a software
MMU, or when it depends on TCG system emulation.

This series replaces 'softmmu' by TCG when relevant,
or simply remove it.

Philippe Mathieu-Daudé (2):
  tests/vm/ubuntu.aarch64: Correct comment about TCG specific delay
  tests/unit/test-seccomp: Remove mentions of softmmu in test names

 tests/unit/test-seccomp.c | 24 ++++++++++++------------
 tests/vm/ubuntu.aarch64   |  2 +-
 2 files changed, 13 insertions(+), 13 deletions(-)

-- 
2.41.0

[PATCH 1/2] tests/vm/ubuntu.aarch64: Correct comment about TCG specific delay

[Philippe Mathieu-Daudé]

Wether we use a software MMU or not to set the SSH timeout
isn't really relevant. What we want to know is if we use
a hardware or software accelerator (TCG).
Replace the 'softmmu' mention by 'TCG'.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 tests/vm/ubuntu.aarch64 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/vm/ubuntu.aarch64 b/tests/vm/ubuntu.aarch64
index 666947393b..eeda281f87 100755
--- a/tests/vm/ubuntu.aarch64
+++ b/tests/vm/ubuntu.aarch64
@@ -25,7 +25,7 @@ DEFAULT_CONFIG = {
                      "apt-get install -y libfdt-dev pkg-config language-pack-en ninja-build",
     # We increase beyond the default time since during boot
     # it can take some time (many seconds) to log into the VM
-    # especially using softmmu.
+    # especially using TCG.
     'ssh_timeout'  : 60,
 }
 
-- 
2.41.0

[PATCH 2/2] tests/unit/test-seccomp: Remove mentions of softmmu in test names

[Philippe Mathieu-Daudé]

Wether we are using a software MMU or not is irrelevant for the
seccomp facility. The facility is restricted to system emulation,
but such detail isn't really helpful, so directly drop the
'softmmu' mention from the test names.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 tests/unit/test-seccomp.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/tests/unit/test-seccomp.c b/tests/unit/test-seccomp.c
index f02c79cafd..bab93fd6da 100644
--- a/tests/unit/test-seccomp.c
+++ b/tests/unit/test-seccomp.c
@@ -229,26 +229,26 @@ int main(int argc, char **argv)
     g_test_init(&argc, &argv, NULL);
     if (can_play_with_seccomp()) {
 #ifdef SYS_fork
-        g_test_add_func("/softmmu/seccomp/sys-fork/on",
+        g_test_add_func("/seccomp/sys-fork/on",
                         test_seccomp_sys_fork_on);
-        g_test_add_func("/softmmu/seccomp/sys-fork/on-nospawn",
+        g_test_add_func("/seccomp/sys-fork/on-nospawn",
                         test_seccomp_sys_fork_on_nospawn);
-        g_test_add_func("/softmmu/seccomp/sys-fork/off",
+        g_test_add_func("/seccomp/sys-fork/off",
                         test_seccomp_sys_fork_off);
 #endif
 
-        g_test_add_func("/softmmu/seccomp/fork/on",
+        g_test_add_func("/seccomp/fork/on",
                         test_seccomp_fork_on);
-        g_test_add_func("/softmmu/seccomp/fork/on-nospawn",
+        g_test_add_func("/seccomp/fork/on-nospawn",
                         test_seccomp_fork_on_nospawn);
-        g_test_add_func("/softmmu/seccomp/fork/off",
+        g_test_add_func("/seccomp/fork/off",
                         test_seccomp_fork_off);
 
-        g_test_add_func("/softmmu/seccomp/thread/on",
+        g_test_add_func("/seccomp/thread/on",
                         test_seccomp_thread_on);
-        g_test_add_func("/softmmu/seccomp/thread/on-nospawn",
+        g_test_add_func("/seccomp/thread/on-nospawn",
                         test_seccomp_thread_on_nospawn);
-        g_test_add_func("/softmmu/seccomp/thread/off",
+        g_test_add_func("/seccomp/thread/off",
                         test_seccomp_thread_off);
 
         if (doit_sched() == 0) {
@@ -256,11 +256,11 @@ int main(int argc, char **argv)
              * musl doesn't impl sched_setscheduler, hence
              * we check above if it works first
              */
-            g_test_add_func("/softmmu/seccomp/sched/on",
+            g_test_add_func("/seccomp/sched/on",
                             test_seccomp_sched_on);
-            g_test_add_func("/softmmu/seccomp/sched/on-nores",
+            g_test_add_func("/seccomp/sched/on-nores",
                             test_seccomp_sched_on_nores);
-            g_test_add_func("/softmmu/seccomp/sched/off",
+            g_test_add_func("/seccomp/sched/off",
                             test_seccomp_sched_off);
         }
     }
-- 
2.41.0

Re: [PATCH 1/2] tests/vm/ubuntu.aarch64: Correct comment about TCG specific delay

[Alex Bennée]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Wether we use a software MMU or not to set the SSH timeout
> isn't really relevant. What we want to know is if we use
> a hardware or software accelerator (TCG).
> Replace the 'softmmu' mention by 'TCG'.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH 0/2] tests: Drop mentions of SoftMMU

[Richard Henderson]

On 10/2/23 07:51, Philippe Mathieu-Daudé wrote:
> We want to clarify when code depends on a software
> MMU, or when it depends on TCG system emulation.
> 
> This series replaces 'softmmu' by TCG when relevant,
> or simply remove it.
> 
> Philippe Mathieu-Daudé (2):
>    tests/vm/ubuntu.aarch64: Correct comment about TCG specific delay
>    tests/unit/test-seccomp: Remove mentions of softmmu in test names
> 
>   tests/unit/test-seccomp.c | 24 ++++++++++++------------
>   tests/vm/ubuntu.aarch64   |  2 +-
>   2 files changed, 13 insertions(+), 13 deletions(-)
> 

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~