From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Cyf6x-0005Q0-QN for qemu-devel@nongnu.org; Tue, 08 Feb 2005 18:49:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Cyf6p-0005Mg-70 for qemu-devel@nongnu.org; Tue, 08 Feb 2005 18:49:32 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Cyf6n-0005KP-ML for qemu-devel@nongnu.org; Tue, 08 Feb 2005 18:49:29 -0500 Received: from [62.210.158.41] (helo=moscou.magic.fr) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Cyeqn-0000yL-AX for qemu-devel@nongnu.org; Tue, 08 Feb 2005 18:32:57 -0500 From: "J. Mayer" In-Reply-To: <1107901543.14935.48.camel@localhost.localdomain> References: <1107891913.14935.17.camel@localhost.localdomain> <1107900694.10555.22.camel@rapid> <1107901543.14935.48.camel@localhost.localdomain> Content-Type: text/plain Message-Id: <1107905574.10555.32.camel@rapid> Mime-Version: 1.0 Date: Wed, 09 Feb 2005 00:32:54 +0100 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: PPC fixes for qemu/OpenHackWare Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thayne Harbaugh Cc: qemu-devel On Tue, 2005-02-08 at 23:25, Thayne Harbaugh wrote: > On Tue, 2005-02-08 at 23:11 +0100, J. Mayer wrote: > > On Tue, 2005-02-08 at 20:45, Thayne Harbaugh wrote: > > > These fixes greatly improve qemu booting on PPC - many Linux > > > distributions with kernel 2.4 now work. It's two big patches (one for > > > qemu, one for OpenHackWare) - let me know if someone prefers them broken > > > out into smaller pieces. > > > > > > There's still some work to be done to get PREP in good shape as well as > > > a Linux 2.6 kernel to work well - expect some more patches in the near > > > future. > > > > Hi. > > Thanks for the work. I need to take a close look of your patches because > > I completely restructured OHW. For example, HFS code is quite different > > in my working repository (but still have problems on some fs)... [...] > > I can't compare OHW for now, as it seems that most of the patch is > > cosmetic (blanks, tabs) and as most files have changed. Could you please > > regenerate the patch using: > > --ignore-all-space --ignore-blank-lines --ignore-space-change --minimal > > -p > > options to make it easier to read ? > > I'm a bit confused. I closely reviewed the patch prior to sending and I > didn't notice any instances of whitespace-only diff. There are, > however, many lines of spelling changes. :) controler -> controller, > recurs -> recurse, to -> too, etc.. Oh well, I looked closer, and you're absolutely right, there are lots of typo I didn't saw at first sight.... I'm sorry about my mistake. But I would still appreciate a diff with -p option, then I have the function name with the diff, which may helps when code has been splitted... -- J. Mayer Never organized