From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Cywws-0007rW-Lk
	for qemu-devel@nongnu.org; Wed, 09 Feb 2005 13:52:27 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Cywwo-0007oh-Dd
	for qemu-devel@nongnu.org; Wed, 09 Feb 2005 13:52:22 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Cywwo-0007mz-96
	for qemu-devel@nongnu.org; Wed, 09 Feb 2005 13:52:22 -0500
Received: from [161.58.242.233] (helo=hotwww5.hotwww.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.34) id 1Cywgk-0002Sd-Vc
	for qemu-devel@nongnu.org; Wed, 09 Feb 2005 13:35:47 -0500
Subject: Re: [Qemu-devel] qemu/hw openpic.c
From: Thayne Harbaugh <thayne@realmsys.com>
In-Reply-To: <E1CyfIU-0002mL-00@savannah>
References: <E1CyfIU-0002mL-00@savannah>
Content-Type: text/plain
Date: Wed, 09 Feb 2005 11:35:38 -0700
Message-Id: <1107974138.584.12.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>

On Tue, 2005-02-08 at 19:01 -0500, Fabrice Bellard wrote:
> CVSROOT:	/cvsroot/qemu
> Module name:	qemu
> Branch: 	
> Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/02/09 00:01:34
> 
> Modified files:
> 	hw             : openpic.c 
> 
> Log message:
> 	spelling fix
> 
> CVSWeb URLs:
> http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/hw/openpic.c.diff?tr1=1.5&tr2=1.6&r1=text&r2=text


There was another change in openpic.c that I haven't seen committed:

@@ -629,7 +629,7 @@
         break;
     case 0x10: /* TIBC */
 	if ((opp->timers[idx].ticc & 0x80000000) != 0 &&
-	    (val & 0x800000000) == 0 &&
+	    (val & 0x80000000) == 0 &&
             (opp->timers[idx].tibc & 0x80000000) != 0)
 	    opp->timers[idx].ticc &= ~0x80000000;
 	opp->timers[idx].tibc = val;


It's because the constant 0x800000000 is larger than a uint32_t (it
appears that the way it was will always cause "(val & 0x800000000) == 0"
to always be true).  I haven't tested it - I just made the change
because it looked "obvious".  Please let me know if there's some black
magic that this "fix" breaks.