From: John Snow <jsnow@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: vsementsov@virtuozzo.com, qemu-devel@nongnu.org,
mreitz@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH for-2.11 0/3] block: Error out on load_vm with active dirty bitmaps
Date: Mon, 20 Nov 2017 19:37:30 -0500 [thread overview]
Message-ID: <110d5277-9e7d-eab9-f40a-bc91797c4c1d@redhat.com> (raw)
In-Reply-To: <20171120145006.551-1-kwolf@redhat.com>
On 11/20/2017 09:50 AM, Kevin Wolf wrote:
> Following the discussing at
> https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg03572.html
> this implements the error return for loading a snapshot while dirty
> bitmaps are active.
>
> Kevin Wolf (3):
> block: Add errp to bdrv_snapshot_goto()
> block: Add errp to bdrv_all_goto_snapshot()
> block: Error out on load_vm with active dirty bitmaps
>
> include/block/snapshot.h | 6 ++++--
> block/snapshot.c | 43 +++++++++++++++++++++++--------------------
> migration/savevm.c | 6 +++---
> qemu-img.c | 6 +++---
> 4 files changed, 33 insertions(+), 28 deletions(-)
>
You have enough reviews, but just so it's unambiguous, I'm fine with
this approach in lieu of Vladimir's; so:
Reviewed-by: John Snow <jsnow@redhat.com>
prev parent reply other threads:[~2017-11-21 0:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 14:50 [Qemu-devel] [PATCH for-2.11 0/3] block: Error out on load_vm with active dirty bitmaps Kevin Wolf
2017-11-20 14:50 ` [Qemu-devel] [PATCH for-2.11 1/3] block: Add errp to bdrv_snapshot_goto() Kevin Wolf
2017-11-20 16:07 ` Vladimir Sementsov-Ogievskiy
2017-11-20 16:23 ` Kevin Wolf
2017-11-20 16:31 ` Vladimir Sementsov-Ogievskiy
2017-11-20 14:50 ` [Qemu-devel] [PATCH for-2.11 2/3] block: Add errp to bdrv_all_goto_snapshot() Kevin Wolf
2017-11-20 16:14 ` Vladimir Sementsov-Ogievskiy
2017-11-20 14:50 ` [Qemu-devel] [PATCH for-2.11 3/3] block: Error out on load_vm with active dirty bitmaps Kevin Wolf
2017-11-20 16:16 ` Vladimir Sementsov-Ogievskiy
2017-11-20 15:14 ` [Qemu-devel] [PATCH for-2.11 0/3] " Eric Blake
2017-11-20 15:21 ` Denis V. Lunev
2017-11-21 0:37 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=110d5277-9e7d-eab9-f40a-bc91797c4c1d@redhat.com \
--to=jsnow@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).