From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
"open list:Network Block Dev..." <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] nbd/client: Relax handling of large NBD_CMD_BLOCK_STATUS reply
Date: Tue, 29 May 2018 19:52:25 -0500 [thread overview]
Message-ID: <110f164d-16ea-090d-2aec-93d774116bf4@redhat.com> (raw)
In-Reply-To: <dd9b008a-0e2e-9a4f-5387-e66aecf6feb3@virtuozzo.com>
On 05/29/2018 10:34 AM, Vladimir Sementsov-Ogievskiy wrote:
> 04.05.2018 01:26, Eric Blake wrote:
>> The NBD spec is proposing a relaxation of NBD_CMD_BLOCK_STATUS
>> where a server may have the final extent per context give a
>> length beyond the original request, if it can easily prove that
>> subsequent bytes have the same status, on the grounds that a
>> client can take advantage of this information for fewer block
>> status requests. Since qemu 2.12 as a client always sends
>> NBD_CMD_FLAG_REQ_ONE, and rejects a server that sends extra
>> length, the upstream NBD spec will probably limit this behavior
>> to clients that don't request REQ_ONE semantics; but it doesn't
>> hurt to relax qemu to always be permissive of this server
>> behavior, even if it continues to use REQ_ONE.
>
> Hi!
>
> Patch is applied, are you going to make a patch for NBD spec?
Yes, thanks for the reminder (lots going on lately).
https://lists.debian.org/nbd/2018/05/msg00042.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2018-05-30 0:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 22:26 [Qemu-devel] [PATCH] nbd/client: Relax handling of large NBD_CMD_BLOCK_STATUS reply Eric Blake
2018-05-03 22:30 ` no-reply
2018-05-03 22:35 ` Eric Blake
2018-05-03 23:22 ` no-reply
2018-05-04 10:40 ` Vladimir Sementsov-Ogievskiy
2018-05-04 13:17 ` Eric Blake
2018-05-29 15:34 ` Vladimir Sementsov-Ogievskiy
2018-05-30 0:52 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=110f164d-16ea-090d-2aec-93d774116bf4@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).