From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DFHpd-0003fJ-Me for qemu-devel@nongnu.org; Sat, 26 Mar 2005 15:24:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DFHpT-0003Wl-1t for qemu-devel@nongnu.org; Sat, 26 Mar 2005 15:24:20 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DFHpS-0003Sv-0R for qemu-devel@nongnu.org; Sat, 26 Mar 2005 15:24:18 -0500 Received: from [62.210.158.46] (helo=teheran.magic.fr) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DFHUF-0004Ee-MB for qemu-devel@nongnu.org; Sat, 26 Mar 2005 15:02:23 -0500 Received: from private2 (ppp-181.net-555.magic.fr [62.210.255.181]) by teheran.magic.fr (8.11.6/8.11.2) with ESMTP id j2QK2GA15354 for ; Sat, 26 Mar 2005 21:02:17 +0100 (CET) Subject: Re: [Qemu-devel] [patch] CPU architecture selection From: "J. Mayer" In-Reply-To: <200503261946.57675.paul@codesourcery.com> References: <200503261946.57675.paul@codesourcery.com> Content-Type: text/plain Date: Sat, 26 Mar 2005 21:02:20 +0100 Message-Id: <1111867340.31144.65.camel@rapid> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sat, 2005-03-26 at 19:46 +0000, Paul Brook wrote: > The attached patch adds a -cpu commandline option to qemu to allow the user to > select what type of CPU is emulated. It currently only does anything useful > for arm targets, but it should be easy to hook other targets into the same > mechanism. > > I implemented the selection as a bitmask. This allows users to select a CPU by > the features it provides, and also allows creation of convenient aliases for > common CPUs. there is a cpu_ppc_register function in target-ppc/translate.c which does what's needed for emulated PPC selection. The CPU is registered from the emulated board definition, ie in hw/ppc_prep.c or hw/ppc_chrp.c. Your patch conflicts with this code. It seems to me that cpu selection should go in board definitions, like all the rest of emulated hardware selection, then have nothing to do in target-xxx/translate.c. -- J. Mayer Never organized