qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "J. Mayer" <l_indien@magic.fr>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Better .dmg autodetection
Date: Tue, 12 Apr 2005 22:51:46 +0200	[thread overview]
Message-ID: <1113339106.28622.196.camel@rapid> (raw)
In-Reply-To: <20050412192841.03d16475@caprice.artificis.hu>

On Tue, 2005-04-12 at 19:28 +0200, Alex Beregszaszi wrote:
> Hi,
> 
> There are quiet lot fake dmg files floating around. These are just raw
> images containing the Apple partition map and HFS partitions.

Those are not fake dmg.
With Apple disk utility, you are free to choose if the dmg is to be
compressed or not.
Then, uncompressed dmg are valid ones.
But, you don't need to manage them in block-dmg,c as those are just raw
images...

[...]
> * last check if the filename ends in .dmg

It seems to me that this check is not to be done.
There's no need to. If the first sector (after decompression, if needed)
is a valid Apple partition map _or_ a valid partition entry (ie with PM
magic at start), then it's a valid dmg. File extensions never mean
anything, they are just a user-interface oriented remainder, imho.

-- 
J. Mayer <l_indien@magic.fr>
Never organized

  reply	other threads:[~2005-04-12 20:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-12 17:28 [Qemu-devel] [PATCH] Better .dmg autodetection Alex Beregszaszi
2005-04-12 20:51 ` J. Mayer [this message]
2005-04-15 16:47   ` Alex Beregszaszi
2005-04-15 23:41     ` J. Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1113339106.28622.196.camel@rapid \
    --to=l_indien@magic.fr \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).