From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tim66-0001X3-Cw for qemu-devel@nongnu.org; Wed, 12 Dec 2012 08:11:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tim5t-0002l6-RQ for qemu-devel@nongnu.org; Wed, 12 Dec 2012 08:11:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tim5t-0002kJ-JY for qemu-devel@nongnu.org; Wed, 12 Dec 2012 08:11:25 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCDBP4Z011977 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Dec 2012 08:11:25 -0500 Received: from redhat.com (vpn1-7-32.ams2.redhat.com [10.36.7.32]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id qBCDBNk4018273 for ; Wed, 12 Dec 2012 08:11:24 -0500 Date: Wed, 12 Dec 2012 15:14:36 +0200 From: "Michael S. Tsirkin" Message-ID: <11139c91ed928db43f1083831a57878faa58ac14.1355318011.git.mst@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [Qemu-devel] [PATCH 8/8] pci_bus: update comment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Don't ask everyone to desist from including this header, simply recommend using accessors. Signed-off-by: Michael S. Tsirkin --- hw/pci/pci_bus.h | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/hw/pci/pci_bus.h b/hw/pci/pci_bus.h index 21d0ce6..8217f61 100644 --- a/hw/pci/pci_bus.h +++ b/hw/pci/pci_bus.h @@ -2,14 +2,10 @@ #define QEMU_PCI_INTERNALS_H /* - * This header files is private to pci.c and pci_bridge.c - * So following structures are opaque to others and shouldn't be - * accessed. + * PCI Bus and Bridge datastructures. * - * For pci-to-pci bridge needs to include this header file to embed - * PCIBridge in its structure or to get sizeof(PCIBridge), - * However, they shouldn't access those following members directly. - * Use accessor function in pci.h, pci_bridge.h + * Do not access the following members directly; + * use accessor functions in pci.h, pci_bridge.h */ #define TYPE_PCI_BUS "PCI" -- MST