From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6DA9C2D0DB for ; Tue, 21 Jan 2020 16:28:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75E7E22525 for ; Tue, 21 Jan 2020 16:28:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bQGUC80c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75E7E22525 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itwNx-0005wO-CS for qemu-devel@archiver.kernel.org; Tue, 21 Jan 2020 11:28:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36976) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itwN6-0004wG-Ps for qemu-devel@nongnu.org; Tue, 21 Jan 2020 11:27:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itwN4-0002vd-A7 for qemu-devel@nongnu.org; Tue, 21 Jan 2020 11:27:20 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:22605 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itwN4-0002vF-6L for qemu-devel@nongnu.org; Tue, 21 Jan 2020 11:27:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579624037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ObnXMVLixb7W8aUnHhyzGhIwT9m7etDtZMKzg1gq/R8=; b=bQGUC80cXDxatKPtcQ9CM0bvzOR+8vzJhCxMsQuAmArrTlVf4/0TBuQMVlmqrBnBItYLPO bU+BeBrgp9QaboJeDCX4675FfT3jVdr3Hy+bnL/cducIaNGGcPSVuVog7UBXCyI6x5I/fu oBDu5dzevWzEBvv5GEJlSyn2gKsuZyM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-173-63d58APiMJKh9Khv7yd3qw-1; Tue, 21 Jan 2020 11:27:15 -0500 Received: by mail-wm1-f70.google.com with SMTP id o24so570788wmh.0 for ; Tue, 21 Jan 2020 08:27:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HpDJDcVh0R2d5kNLvddhR3AlT9Puti21RBbZkMveJ6c=; b=HMPAvVe/Y4vAs8jRvcX069DOicYyKnEe+u/oGwY1jjJdelsKR/+Qbr4JRtobxDPhnz nBkNrArV3m9b4CnS0AwLrU1L83nPDey1E7e+1eepSj/y19b4hBttycWzZO5g2SrJR9Pv BBvn7zdEVFD9Z7AJgpBBJAEvZavZUwWXGWOqViS8iVA0w4sdEt56kWkoelOHbsDmPHiP OH+LSkyZHQuTFKjsLh6td82rMix8/P2iUy0JJVfKr6rXFcvV4ioF/2t1gTVOHXcjM0W8 FYuyBB03qU1oqLg+k6TX/j/2ri+hgME07NEFUIQfgGoI21iLPjYJu30QmCEKxRzd7BH+ m7nA== X-Gm-Message-State: APjAAAVR4n0NQpKVW6UkEdW+jwxVaxft60tTwswI1n4LUGtMRYkkype2 ZtekorpXGjRprn+3X6bYm2bJsbGCyBDToO8nkDeSEpBs2amSL6HgKfTOfyPpLQZMjONDDHqMAq7 QuLO/UtW5So4SEAA= X-Received: by 2002:a1c:1f51:: with SMTP id f78mr5069387wmf.60.1579624033851; Tue, 21 Jan 2020 08:27:13 -0800 (PST) X-Google-Smtp-Source: APXvYqyyt69KzBvbuxGLLp5BGEUiMBLKEqADj7SKKb1zdPXFkGoSUKOBebmHCtzdW2zW6+Wi+Oil9A== X-Received: by 2002:a1c:1f51:: with SMTP id f78mr5069355wmf.60.1579624033557; Tue, 21 Jan 2020 08:27:13 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:b509:fc01:ee8a:ca8a? ([2001:b07:6468:f312:b509:fc01:ee8a:ca8a]) by smtp.gmail.com with ESMTPSA id q3sm4337331wmj.38.2020.01.21.08.27.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2020 08:27:12 -0800 (PST) Subject: Re: [PATCH v2 00/10] Cleanups around the 'current_machine' global variable To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200121110349.25842-1-philmd@redhat.com> From: Paolo Bonzini Message-ID: <11145254-2dfe-a699-2f92-b11b287d7ab8@redhat.com> Date: Tue, 21 Jan 2020 17:27:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20200121110349.25842-1-philmd@redhat.com> Content-Language: en-US X-MC-Unique: 63d58APiMJKh9Khv7yd3qw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cornelia Huck , Eduardo Habkost , Like Xu , David Hildenbrand , Marcelo Tosatti , Markus Armbruster , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Richard Henderson , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 21/01/20 12:03, Philippe Mathieu-Daud=C3=A9 wrote: > v1 was "Replace current_machine by qdev_get_machine()": > https://www.mail-archive.com/qemu-devel@nongnu.org/msg669611.html >=20 > But Markus objected, see: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg670122.html > and older discussion: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg611338.html >=20 > This series salvage patches from v1, and add other trivial cleanups. >=20 > Can the ARM/PPC/S390 patches could go via their own tree, and the > rest via Paolo's 'misc' tree? I think they're trivial enough so (with the exception of patch 7) I have queued them. Paolo