From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DXgWT-0006uE-In
	for qemu-devel@nongnu.org; Mon, 16 May 2005 10:24:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DXbPQ-0004cf-Ky
	for qemu-devel@nongnu.org; Mon, 16 May 2005 04:58:21 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DXaVR-00070G-W8
	for qemu-devel@nongnu.org; Mon, 16 May 2005 03:59:18 -0400
Received: from [63.228.1.57] (helo=gate.crashing.org)
	by monty-python.gnu.org with esmtp
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1DXabB-0006xf-Q7
	for qemu-devel@nongnu.org; Mon, 16 May 2005 04:05:14 -0400
Received: from gaston (localhost [127.0.0.1])
	by gate.crashing.org (8.12.8/8.12.8) with ESMTP id j4G7oegJ004960
	for <qemu-devel@nongnu.org>; Mon, 16 May 2005 02:50:41 -0500
Subject: Re: [Qemu-devel] [Patch] target-ppc mtcrf instruction not recognized
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
In-Reply-To: <1116158429.12010.80.camel@rapid>
References: <1A902C2A-9E03-42FB-BBFC-B84AA84A5A3E@free.fr>
	<1116094547.12010.73.camel@rapid>
	<4920FD1A-05D0-4A7C-BCE6-58036B198978@free.fr>
	<1116158429.12010.80.camel@rapid>
Content-Type: text/plain
Date: Mon, 16 May 2005 17:54:45 +1000
Message-Id: <1116230086.5095.107.camel@gaston>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org


> OK, I did put this in my working repository and I'll submit this to
> Fabrice.
> Please try to do this change to check if other bits need to be relax or
> not:
> 
> Index: target-ppc/translate.c
> ===================================================================
> RCS file: /cvsroot/qemu/qemu/target-ppc/translate.c,v
> retrieving revision 1.31
> diff -u -r1.31 translate.c
> --- target-ppc/translate.c      12 May 2005 18:46:11 -0000      1.31
> +++ target-ppc/translate.c      14 May 2005 17:14:35 -0000
> @@ -2123,7 +2123,7 @@
>  }
>  
>  /* mtcrf */
> -GEN_HANDLER(mtcrf, 0x1F, 0x10, 0x04, 0x00100801, PPC_MISC)
> +GEN_HANDLER(mtcrf, 0x1F, 0x10, 0x04, 0x00000801, PPC_MISC)
>  {
>      gen_op_load_gpr_T0(rS(ctx->opcode));
>      gen_op_store_cr(CRM(ctx->opcode));
> 
> And maybe someone should fill an Apple bug report to tell them their as
> is buggy ;-)

It is definitely a bug in Apple assembler I would say, so I suggest you
add a comment in the above patch in order to avoid somebody later on
"fixing" your mask :)

Ben.