From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DaAdD-00036V-2m
	for qemu-devel@nongnu.org; Mon, 23 May 2005 06:57:59 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DaAdC-00036I-4Y
	for qemu-devel@nongnu.org; Mon, 23 May 2005 06:57:58 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DaAcn-0002qe-Ab
	for qemu-devel@nongnu.org; Mon, 23 May 2005 06:57:33 -0400
Received: from [62.210.158.45] (helo=quito.magic.fr)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1DaAdA-0002PD-49
	for qemu-devel@nongnu.org; Mon, 23 May 2005 06:57:56 -0400
Received: from private2 (ppp-181.net-555.magic.fr [62.210.255.181])
	by quito.magic.fr (8.11.6/8.11.2) with ESMTP id j4NAmRC03299
	for <qemu-devel@nongnu.org>; Mon, 23 May 2005 12:48:27 +0200 (CEST)
Subject: Re: [Qemu-devel] There is a bug in ppc_prep.c?
From: "J. Mayer" <l_indien@magic.fr>
In-Reply-To: <4290D88C.5020004@co.inet.fi>
References: <4290D88C.5020004@co.inet.fi>
Content-Type: text/plain
Date: Mon, 23 May 2005 12:48:28 +0200
Message-Id: <1116845308.15980.98.camel@rapid>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, 2005-05-22 at 22:07 +0300, Tero Kaarlela wrote:
> Hi,
> 
>      I just browsed CVS repository and found following from ppc_prep.c:
> 
>        
> 
> /* Check LE mode */
>         if (val & 0x02) {
>             printf("Little Endian mode isn't supported (yet ?)\n");
>             abort();
> 
>    shouldnt this be ie:
> 
> /* Check LE mode */
>         if (val & 0x02) {
>             printf("Switching to Little Endian mode...");
>            /* abort(); */
> 
> 
> ?

This is supposed to be needed for endian mode switch. However, we have
seen with OS/2 that it would be needed to do nothing when this bit is
set, then I'd prefer to do nothing: that only means, imho, that we don't
know what need to be swapped. Then I'd better not have the feature than
do sthing that I know is a bug (ie does not correspond to platform
specification).
Then, I did let this untouched in the repository.

-- 
J. Mayer <l_indien@magic.fr>
Never organized