qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "John R. Hogerhuis" <jhoger@pobox.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Anyone familiar with the slirp code?
Date: Fri, 22 Jul 2005 09:47:13 -0700	[thread overview]
Message-ID: <1122050833.6034.400.camel@aragorn> (raw)
In-Reply-To: <20050722155125.GC3558@cel.leo>

I don't think the original author anticipated or cared about slirp being
ported to a 64-bit processor. I won't speak for the quality of the code
in general, but on a 32-bit machine the pointer size is 32-bit. It's
perfectly safe on that platform to use any 32-bit spot as a hidey hole
for your cookies.

Things like this is why porting from 32-bit to 64-bit is hard. Frankly I
wonder at the reason for increasingly higher word sizes on machines. Is
the bulk of our data these days really 64-bits long? But I digress...

Just go for it. The slirp code was imported into qemu. At this point
you're probably as much an expert as anyone. There is no upstream
maintainer for the code either, I looked and found and asked the last
sucker that had maintained it for a bit, and he just wanted to unload
it.

If you fix it though, be prepared for the fact that you will be the new
expert ;-)

One thing I'd like to see long term is to completely remove the NAT code
and replace it with something more modern and robust like netfilter.
That would give us a lot of nice application level gateways (nat
modules) for important protocols, and some tweakable firewall settings
for user-net.

While I'm wishing, in fact it would be a nice feature in general for
QEMU to have a built in firewall pointed at each host with fairly
minimal permissions by default. A windows machine on your network is a
windows machine on your network, virtual or not :-)

-- John.

  reply	other threads:[~2005-07-22 16:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-22 15:51 [Qemu-devel] Anyone familiar with the slirp code? Paul LeoNerd Evans
2005-07-22 16:47 ` John R. Hogerhuis [this message]
2005-07-22 18:14   ` Paul LeoNerd Evans
2005-07-22 18:45 ` Gwenole Beauchesne
2005-07-22 22:05   ` Jim C. Brown
2005-07-22 22:53     ` Gwenole Beauchesne
2005-07-23  4:15       ` Jim C. Brown
2005-07-24 18:09         ` Adrian Smarzewski
2005-07-22 22:29 ` Josh Metzler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1122050833.6034.400.camel@aragorn \
    --to=jhoger@pobox.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).