From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33059)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bwWGh-0003Ke-2j
	for qemu-devel@nongnu.org; Tue, 18 Oct 2016 11:25:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bwWGd-0001k9-5Z
	for qemu-devel@nongnu.org; Tue, 18 Oct 2016 11:25:31 -0400
Received: from mx6-phx2.redhat.com ([209.132.183.39]:38568)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mlureau@redhat.com>) id 1bwWGc-0001ja-Vg
	for qemu-devel@nongnu.org; Tue, 18 Oct 2016 11:25:27 -0400
Date: Tue, 18 Oct 2016 11:25:21 -0400 (EDT)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <1124121564.320248.1476804321305.JavaMail.zimbra@redhat.com>
In-Reply-To: <7FD18897-996A-489F-9E9A-A51FB417863A@nutanix.com>
References: <20161018092405.21829-1-marcandre.lureau@redhat.com>
	<20161018092405.21829-6-marcandre.lureau@redhat.com>
	<7FD18897-996A-489F-9E9A-A51FB417863A@nutanix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 5/6] contrib: add libvhost-user
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Felipe Franciosi <felipe@nutanix.com>
Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org, victork@redhat.com, mst@redhat.com

Hi Felipe

----- Original Message -----
> Hello,
>=20
> > On 18 Oct 2016, at 10:24, Marc-Andr=C3=A9 Lureau <marcandre.lureau@redh=
at.com>
> > wrote:
> >=20
> > <...>
> >=20
> > diff --git a/contrib/libvhost-user/libvhost-user.h
> > b/contrib/libvhost-user/libvhost-user.h
> >=20
> > <...>
> >=20
> > +#define VHOST_MAX_NR_VIRTQUEUE 8
> > +#define VIRTQUEUE_MAX_SIZE 1024
>=20
> I think that the maximum number of VQs should be 1024 to match Qemu's.
>=20
> http://git.qemu.org/?p=3Dqemu.git;a=3Dblob;f=3Dinclude/hw/virtio/virtio.h=
;h=3Db913aac45589449bcc5d8161651332f4b0d69c7f;hb=3DHEAD#l55

That would make the VuDev structure quite big. We may want to set the nr of=
 max queues in vu_init() instead, and allocate it there. I think this is ra=
ther a current limitation, but does not prevent iterating from there.