From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E6fFt-0004Ac-Ir for qemu-devel@nongnu.org; Sat, 20 Aug 2005 22:08:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E6fFh-000429-7y for qemu-devel@nongnu.org; Sat, 20 Aug 2005 22:08:02 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E6fFg-00040F-Jw for qemu-devel@nongnu.org; Sat, 20 Aug 2005 22:08:00 -0400 Received: from [209.197.145.105] (helo=mx02.cybersurf.com) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1E6f50-0005Bq-Dq for qemu-devel@nongnu.org; Sat, 20 Aug 2005 21:56:58 -0400 Received: from mail.cyberus.ca ([209.197.145.21]) by mx02.cybersurf.com with esmtp (Exim 4.30) id 1E6f4m-0002Dx-T6 for qemu-devel@nongnu.org; Sat, 20 Aug 2005 21:56:44 -0400 Subject: Re: [Qemu-devel] patch: allow defining MAC address etc From: jamal In-Reply-To: <200508210204.32388.paul@codesourcery.com> References: <1124584572.6521.38.camel@localhost.localdomain> <200508210204.32388.paul@codesourcery.com> Content-Type: text/plain Date: Sat, 20 Aug 2005 21:56:33 -0400 Message-Id: <1124589394.6521.51.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: hadi@cyberus.ca, qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On Sun, 2005-21-08 at 02:04 +0100, Paul Brook wrote: > On Sunday 21 August 2005 01:36, jamal wrote: > > This attached patch is intended for allowing automated clever scripting > > for networking (tuntap only). Please read and apply if possible. > > > > It does the following: > > a) allow for specifying the guest netdevice interface MAC address > > (in addition to keeping the old functionality of specifying just > > the first one and letting qemu decide what subsequent ones should be) > > So now you can say something along the lines of: > > "-nics 2 -macaddr0 00:11:a:0:2:19 -macaddr1 00:11:a:0:1:19" > > We allow upto 6 such MAC addresses to be specified. Maybe theres > > a more clever way to achieve this. > > Maybe a comma separated list of MAC addresses. e.g. > "-nics 2 macaddr 00:11:a:0:2:19,00:11:a:0:1:19" > i could do this; macaddr is already being used to imply the start macaddr. Does macaddrs sound better? > Whatever you do, you should really support up to MAX_NICS addresses. > ok > > b) allows to specify an opaque integer to be passed to the host script. > > Such an integer is useful if you are creating many NICs and you want > > to do different things depending on what this extra parameter is; > > example you may wanna add/del a route for one but not other > > syntax is of the form: "-ID1 1 -ID2 2" > > The IDs are mapped to the NICs. i.e ID1 maps to the first NIC > > and ID2 to the second etc. If you dont specify an ID, a 0 is used. > > Just like NICS/MACs we allow upto 6 such IDs to be specified. > > Wouldn't it make more sense to just pass the mac address and/or the NIC > number? Introducing yet another value seems unnecessarily complicated. > The NIC number would not be sufficient for what i want; As an example, I could use the ID to tell me the "type" of processing needed. Example test script: --- if [ $2 = "0" ]; then #not really visible from host /usr/sbin/brctl addif base $1 /sbin/ifconfig $1 up fi if [ $2 = "1" ]; then ..... ... fi if [ $2 = "2" ]; then #visible from host; give it an IP address /sbin/ifconfig $1 10.0.3.24 netmask 255.255.255.0 up /sbin/route add 10.0.3.25 dev $1 fi --------- If i was to get rid of anything it probably would be the MAC address of the guest since this is a host side setup. So i would like to keep the ID but could let go of the guest MAC. Thoughts? cheers, jamal