From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6yMH-0007CK-6T for qemu-devel@nongnu.org; Wed, 07 Aug 2013 03:40:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6yMB-0001z9-4F for qemu-devel@nongnu.org; Wed, 07 Aug 2013 03:40:37 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:34198) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6yMA-0001yv-Nd for qemu-devel@nongnu.org; Wed, 07 Aug 2013 03:40:30 -0400 Date: Wed, 7 Aug 2013 03:40:28 -0400 (EDT) From: Paolo Bonzini Message-ID: <1126524175.10530041.1375861228957.JavaMail.root@redhat.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: owasserm@redhat.com, mrhines@us.ibm.com, qemu-devel@nongnu.org, quintela@redhat.com > RDMAControlHeader::len is remote-provided. So validate the value before use. > > Isaku Yamahata (3): > rdma: use resp.len after validation in qemu_rdma_registration_stop > rdma: validate RDMAControlHeader::len > rdma: check if RDMAControlHeader::len match transferred byte > > migration-rdma.c | 44 ++++++++++++++++++++++++++++++-------------- > 1 file changed, 30 insertions(+), 14 deletions(-) Looks good, thanks! We will have a mix of assertions and errors after this patch. Asserting on the destination is probably okay, but as a follow-up perhaps we can change the assertion(s) to errors. Paolo