From: John Snow <jsnow@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Fam Zheng <fam@euphon.net>,
qemu-block@nongnu.org
Subject: Re: [PATCH] tests/Makefile: test-image-locking needs CONFIG_POSIX
Date: Mon, 3 Aug 2020 17:23:20 -0400 [thread overview]
Message-ID: <11268c07-aca7-c3c1-d597-80326b6fefbc@redhat.com> (raw)
In-Reply-To: <20200803065803.20836-1-thuth@redhat.com>
On 8/3/20 2:58 AM, Thomas Huth wrote:
> test-image-locking.c uses the qemu_lock_fd_test() function which is
> only available on Posix-like systems.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> tests/Makefile.include | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 5ff731be2b..430119db74 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -87,7 +87,9 @@ check-unit-$(CONFIG_BLOCK) += tests/test-blockjob$(EXESUF)
> check-unit-$(CONFIG_BLOCK) += tests/test-blockjob-txn$(EXESUF)
> check-unit-$(CONFIG_BLOCK) += tests/test-block-backend$(EXESUF)
> check-unit-$(CONFIG_BLOCK) += tests/test-block-iothread$(EXESUF)
> +ifeq ($(CONFIG_POSIX),y)
> check-unit-$(CONFIG_BLOCK) += tests/test-image-locking$(EXESUF)
> +endif
> check-unit-y += tests/test-x86-cpuid$(EXESUF)
> # all code tested by test-x86-cpuid is inside topology.h
> ifeq ($(CONFIG_SOFTMMU),y)
>
prev parent reply other threads:[~2020-08-03 21:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 6:58 [PATCH] tests/Makefile: test-image-locking needs CONFIG_POSIX Thomas Huth
2020-08-03 21:23 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11268c07-aca7-c3c1-d597-80326b6fefbc@redhat.com \
--to=jsnow@redhat.com \
--cc=fam@euphon.net \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).