From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: michael.roth@amd.com, berrange@redhat.com, jsnow@redhat.com
Subject: Re: [PATCH] scripts/qapi/backend: Clean up create_backend()'s failure mode
Date: Tue, 11 Mar 2025 08:22:25 +0100 [thread overview]
Message-ID: <1128bbf1-363f-4ce6-b58a-655f3e141ccd@linaro.org> (raw)
In-Reply-To: <20250311065352.992307-1-armbru@redhat.com>
On 11/3/25 07:53, Markus Armbruster wrote:
> create_backend()'s caller catches QAPIError, and returns non-zero exit
> code on catch. The caller's caller passes the exit code to
> sys.exit().
>
> create_backend() doesn't care: it reports errors to stderr and
> sys.exit()s.
>
> Change it to raise QAPIError instead.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qapi/main.py | 24 +++++++++---------------
> 1 file changed, 9 insertions(+), 15 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2025-03-11 7:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 6:53 [PATCH] scripts/qapi/backend: Clean up create_backend()'s failure mode Markus Armbruster
2025-03-11 7:22 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1128bbf1-363f-4ce6-b58a-655f3e141ccd@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).