From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayitP-0006Of-5S for qemu-devel@nongnu.org; Fri, 06 May 2016 12:46:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayitD-0002sf-H7 for qemu-devel@nongnu.org; Fri, 06 May 2016 12:46:13 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:36120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayitC-0002ou-AY for qemu-devel@nongnu.org; Fri, 06 May 2016 12:46:07 -0400 Received: by mail-qk0-x244.google.com with SMTP id l68so7590352qkf.3 for ; Fri, 06 May 2016 09:45:52 -0700 (PDT) Sender: Richard Henderson References: <1462392752-17703-1-git-send-email-laurent@vivier.eu> <1462392752-17703-12-git-send-email-laurent@vivier.eu> From: Richard Henderson Message-ID: <112be92e-e89e-f873-dbba-9dacca42ad6d@twiddle.net> Date: Fri, 6 May 2016 06:45:43 -1000 MIME-Version: 1.0 In-Reply-To: <1462392752-17703-12-git-send-email-laurent@vivier.eu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/52] target-m68k: allow to update flags with operation on words and bytes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Cc: gerg@uclinux.org, schwab@linux-m68k.org, agraf@suse.de On 05/04/2016 10:11 AM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > target-m68k/cpu.h | 14 ++++- > target-m68k/helper.c | 139 ++++++++++++++++++++++++++++++++++-------------- > target-m68k/translate.c | 82 ++++++++++++++-------------- > 3 files changed, 151 insertions(+), 84 deletions(-) I wonder if this shouldn't just be dropped, or squished into some of the other flags-related patches? That said, Reviewed-by: Richard Henderson r~