From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88545C4332F for ; Sat, 17 Dec 2022 00:39:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6LE7-0007Pl-5Q; Fri, 16 Dec 2022 19:38:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6LE0-0007KV-E1 for qemu-devel@nongnu.org; Fri, 16 Dec 2022 19:38:48 -0500 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6LDy-0005HW-Qh for qemu-devel@nongnu.org; Fri, 16 Dec 2022 19:38:48 -0500 Received: by mail-pf1-x431.google.com with SMTP id g1so2858216pfk.2 for ; Fri, 16 Dec 2022 16:38:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iZ7t150LD+fHFcVkoHUY4qdqwU8UWj1E+gqLmH6I/EE=; b=GMNos0pBK5YBIMoKQS3Ymay1SCIwr/ZQEGZq/NCxfj9tHnVBMMQYz5T9swoMoy0I0Q Sktu0bKQriT+ZG52ui+sQRoVwOrd5xs90Y5kcWJ7BuvJd/xgKHs7w1XOcshIKKHr2N/U WgXXfV3nlttpkSKp41uqcCmFkVlacxFrb5e17Nv01iCuNsRhnVHBhi3NcY14jexNn6Xj A85zExGuN4BKvNPzvBKJB5ybDuNIguv6sLROpf2hxNKPlamuRn0aCGKEQtc0PC5RR3OR s9TPbAVec1gTSbEi3jwr37l9xwu4mETNxoGy4wFAfPW+H+p2cmf/UeD936rwlLr9QPQo 7HfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iZ7t150LD+fHFcVkoHUY4qdqwU8UWj1E+gqLmH6I/EE=; b=6xAx415xEbvgI0k/qEzmlf1Ze6xlEwemApLAOHp6K3s0qCDvq3KwzEMEQO7T556p6W +7PkaCCcCiO7saKV8mi8zCDe163zV566REX05YzfaQyYEF72FYqcgLaGE+dF6HKas1YY NwfHLiWm9FIeLbkTz1lKqAYin8R4Od/75/YFp5WberLG6VRQYO9CHFubPZyTh0mBiYs2 ExCWnoOyghdtaVdl5oA3SytctXewKOw0hgwnL9y+7DAC4rlAY/AteYt35q79vecAiK9D woZ3gtvSLoD+wDG0LpZcNwksKPTza+iPiCzayp3TR3Vd4DLcx0+fFXe/XcxmFAXEqfHl uYvA== X-Gm-Message-State: ANoB5plRBcCqIS/U34Zurs7mBIYfU7pnbRdF6wx/hez9MxGZSiAOfE2D ZCW048lmJJyPAEs4fQ8+qXDTqg== X-Google-Smtp-Source: AA0mqf6/qpPwiLD2/H4bc7cnsJ4tYlMqYGdPQVN/nFfkgupuAOsC9wbNKNzN/7bXayMuqv84+/pGWA== X-Received: by 2002:aa7:82d7:0:b0:575:a4f5:7812 with SMTP id f23-20020aa782d7000000b00575a4f57812mr33286755pfn.4.1671237525350; Fri, 16 Dec 2022 16:38:45 -0800 (PST) Received: from ?IPV6:2602:47:d48c:8101:c606:9489:98df:6a3b? ([2602:47:d48c:8101:c606:9489:98df:6a3b]) by smtp.gmail.com with ESMTPSA id c20-20020aa79534000000b005779110635asm2064557pfp.51.2022.12.16.16.38.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 16:38:44 -0800 (PST) Message-ID: <112ddce1-ffc4-d50b-9cc8-72578faba11d@linaro.org> Date: Fri, 16 Dec 2022 16:38:43 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 07/10] target/ppc/internal: Restrict MMU declarations to sysemu Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , David Gibson , Xiaojuan Yang , Mark Cave-Ayland , Bin Meng , Artyom Tarasenko , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Song Gao , Alistair Francis , qemu-ppc@nongnu.org, Laurent Vivier , Palmer Dabbelt , Taylor Simpson , Greg Kurz , qemu-riscv@nongnu.org, Max Filippov References: <20221216220539.7065-1-philmd@linaro.org> <20221216220539.7065-8-philmd@linaro.org> From: Richard Henderson In-Reply-To: <20221216220539.7065-8-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 12/16/22 14:05, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > target/ppc/internal.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/target/ppc/internal.h b/target/ppc/internal.h > index 337a362205..901bae6d39 100644 > --- a/target/ppc/internal.h > +++ b/target/ppc/internal.h > @@ -242,9 +242,12 @@ static inline int prot_for_access_type(MMUAccessType access_type) > g_assert_not_reached(); > } > > +#ifndef CONFIG_USER_ONLY > + > /* PowerPC MMU emulation */ > > typedef struct mmu_ctx_t mmu_ctx_t; > + > bool ppc_xlate(PowerPCCPU *cpu, vaddr eaddr, MMUAccessType access_type, > hwaddr *raddrp, int *psizep, int *protp, > int mmu_idx, bool guest_visible); > @@ -266,6 +269,8 @@ struct mmu_ctx_t { > int nx; /* Non-execute area */ > }; > > +#endif /* !CONFIG_USER_ONLY */ Eh. I suppose. Reviewed-by: Richard Henderson r~