From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYZ9k-00063D-4V for qemu-devel@nongnu.org; Wed, 24 Feb 2016 08:07:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYZ9f-0000Vw-5f for qemu-devel@nongnu.org; Wed, 24 Feb 2016 08:07:04 -0500 Received: from mx4-phx2.redhat.com ([209.132.183.25]:53377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYZ9e-0000Vo-T5 for qemu-devel@nongnu.org; Wed, 24 Feb 2016 08:06:59 -0500 Date: Wed, 24 Feb 2016 08:06:57 -0500 (EST) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <113129844.26771667.1456319217157.JavaMail.zimbra@redhat.com> In-Reply-To: <1a724e97cb587624d6f6009c15395496bccfa32b.1456317738.git.mprivozn@redhat.com> References: <1a724e97cb587624d6f6009c15395496bccfa32b.1456317738.git.mprivozn@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spice/gl: Enable dmabuf only for spice >= 0.13.1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Privoznik Cc: marcandre lureau , qemu-devel@nongnu.org, kraxel@redhat.com Hi ----- Original Message ----- > After 474114b7 the dmabuf feature is enabled whenever spice > greater than or equal to spice 0.13.0 is found. This is because > two new functions are required: spice_qxl_gl_scanout and > spice_qxl_gl_draw_async. These were, however, introduce in 0.13.1 > release. Well, technically they haven't been released yet, but > for sure they are not going to be part of 0.13.0 release (for the > ABI stability sake). > > Signed-off-by: Michal Privoznik Ack (that was part too of my previous review comments btw) > --- > include/ui/spice-display.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h > index 69a222b..30ccfe3 100644 > --- a/include/ui/spice-display.h > +++ b/include/ui/spice-display.h > @@ -25,7 +25,7 @@ > #include "sysemu/sysemu.h" > > #if defined(CONFIG_OPENGL_DMABUF) > -# if SPICE_SERVER_VERSION >= 0x000d00 /* release 0.13.0 */ > +# if SPICE_SERVER_VERSION >= 0x000d01 /* release 0.13.1 */ > # define HAVE_SPICE_GL 1 > # include "ui/egl-helpers.h" > # include "ui/egl-context.h" > -- > 2.4.10 > >