From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F4219E7718A for ; Fri, 20 Dec 2024 10:42:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOaSc-0001Hj-NZ; Fri, 20 Dec 2024 05:42:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOaSa-0001Gi-NE for qemu-devel@nongnu.org; Fri, 20 Dec 2024 05:42:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOaSZ-00059s-21 for qemu-devel@nongnu.org; Fri, 20 Dec 2024 05:42:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734691338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RiLj6mUbJeVinFgfTdj/iy+kkIwEHS+i4QSO4k6Shek=; b=dsMdMZBcdE216Jv4ugETMGC4WP6eu+UfONT0pOz8YIEtGrOzqak9FG9S/QD46qM06n9cV1 /ijG3jFMw+CxP4Ewce2tpn6W3JuYDURj5FNL/lifAn5nufqU23FPv8liUc3Pv7w8Ml18di aDvargQqMSpK8v4yG+KY6qtVwdMxntw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-E-Wr8RswNguaNhhBevnz1A-1; Fri, 20 Dec 2024 05:42:12 -0500 X-MC-Unique: E-Wr8RswNguaNhhBevnz1A-1 X-Mimecast-MFC-AGG-ID: E-Wr8RswNguaNhhBevnz1A Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4361fc2b2d6so10244125e9.3 for ; Fri, 20 Dec 2024 02:42:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734691331; x=1735296131; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RiLj6mUbJeVinFgfTdj/iy+kkIwEHS+i4QSO4k6Shek=; b=v+4Vx9vsIcWFxRD6Sc6YTYymLJaaoVJ3JERAwYmR2NaRmFvNlDfd/9gOMDKZhHG+tG +8Gd3efh8I3psKFOQOwyTHZFuFgsvH4ojgrFbqmrfAViKha9vQGRHUqzfnQuhnwYYWlA WqDu/O0md8CV+leubHYeR4grvvtoY1f1ltb4vsrOjjIie1SV8hbyXthU/avVBejLSt3Y TpOopiVA4rlRW7Oid7wUL96Ev+X4euzf1cFDM/Xs4HIZnUgTIfiPdSkpg7H8EXjm0LX2 nscc00P/Br0UMt//9rWSu2mNcrDguCW5d43N3+5bACxpODZlgCItWbJqPEomvkTNwc86 GgSg== X-Forwarded-Encrypted: i=1; AJvYcCVNvfy+FhxEPYnedCqp12mV1WVzCxLHYcCB1PsuFjBCHnSTAWh2zLU46ejBdCAy2YiamT0zE8wf4pwf@nongnu.org X-Gm-Message-State: AOJu0YwyIry5gtTS15CRtKLKbPwipFX3sp+oSqYQtaI4fklQj3awQkaC 6n4MUwU/63GXj+FyCN3+JsiodRKAvwmuS7+URduCXjEq81hVsnpoouv8arMWEMod6efVM9lPRLw R1+VGIsfCPVj3p+oyURF5c7UVwVXLkRBzJDcRE1kTPCtmVmTta50v X-Gm-Gg: ASbGncunhUBdkzCrhydZ9NSl1MZi4kAy/hmWkfszcPpSxSz6QVig/r4LPRPmaoUsA8E 4YbXL4hSZfsCkq0fLbdDTRi4Q9iSKfFm+YTRsY7qiGuPHA3qs54F6WpKlTNysus3E9HHp6IWCaH fZg69cJ6IaRjOGHygJ70EUXZ9H1gSOBKat6krp2/0wco6oe9Ef9G+lnG+XVKOWUOLnPoZKa4Lj1 A+qzryeNPVFK4eFP7+KvytiHzJRa+YMoWNy1CGEszhTYAzcjF4UnSecQjj8 X-Received: by 2002:a05:600c:3554:b0:434:a923:9310 with SMTP id 5b1f17b1804b1-43668646103mr21720875e9.15.1734691331160; Fri, 20 Dec 2024 02:42:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IELSWh+Yjo7RWjg5pk73j1dat1cBQy0Q+vAayVsFGvGSSFWzwowK0WiFBpb5/HL6ELa5gR5dw== X-Received: by 2002:a05:600c:3554:b0:434:a923:9310 with SMTP id 5b1f17b1804b1-43668646103mr21720555e9.15.1734691330751; Fri, 20 Dec 2024 02:42:10 -0800 (PST) Received: from [192.168.10.27] ([151.81.118.45]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-43656b3b2a4sm75847335e9.27.2024.12.20.02.42.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 02:42:10 -0800 (PST) Message-ID: <1132197a-17ab-4b70-ad70-c6a033e18647@redhat.com> Date: Fri, 20 Dec 2024 11:42:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Paolo Bonzini Subject: Re: [PULL 12/40] rust: build integration test for the qemu_api crate To: Bernhard Beschow , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Alex_Benn=C3=A9e?= , Junjie Mao , Kevin Wolf , Manos Pitsidianakis , Pierrick Bouvier , Zhao Liu References: <20241104172721.180255-1-pbonzini@redhat.com> <20241104172721.180255-13-pbonzini@redhat.com> <05747238-adac-4be1-b516-358a04aca803@redhat.com> Content-Language: en-US Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <05747238-adac-4be1-b516-358a04aca803@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.116, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Dec 19, 2024 at 12:22 PM Paolo Bonzini wrote: > > On 12/19/24 10:53, Bernhard Beschow wrote: > > > > > > Am 4. November 2024 17:26:51 UTC schrieb Paolo Bonzini : > >> Adjust the integration test to compile with a subset of QEMU object > >> files, and make it actually create an object of the class it defines. > >> > >> Follow the Rust filesystem conventions, where tests go in tests/ if > >> they use the library in the same way any other code would. > >> > >> Reviewed-by: Junjie Mao > >> Reviewed-by: Kevin Wolf > >> Signed-off-by: Paolo Bonzini > >> --- > >> meson.build | 10 ++++- > >> rust/qemu-api/meson.build | 26 ++++++++++-- > >> rust/qemu-api/src/lib.rs | 3 -- > >> rust/qemu-api/src/tests.rs | 49 ---------------------- > >> rust/qemu-api/tests/tests.rs | 78 ++++++++++++++++++++++++++++++++++++ > >> 5 files changed, 110 insertions(+), 56 deletions(-) > >> delete mode 100644 rust/qemu-api/src/tests.rs > >> create mode 100644 rust/qemu-api/tests/tests.rs > > > > When `--enable-modules` is passed to configure, this patch results in numerous undefined symbols. > > Thanks for the report... This doesn't seem easy to fix without adding > more hacks on top, but I'll try to do it right. Which might very well be doing it in Meson. One needs to teach Meson to add --start-group/--end-group options for rustc just like Meson does for the C compiler; or alternatively to support "objects: ..." for Rust executables. For example, with https://github.com/mesonbuild/meson/pull/14026, the fix is simply this: diff --git a/rust/qemu-api/meson.build b/rust/qemu-api/meson.build index 9425ba7100c..0c08d2e51f5 100644 --- a/rust/qemu-api/meson.build +++ b/rust/qemu-api/meson.build @@ -59,7 +59,8 @@ test('rust-qemu-api-integration', rust_args: ['--test'], install: false, dependencies: [qemu_api, qemu_api_macros], - link_whole: [rust_qemu_api_objs, libqemuutil]), + link_with: libqemuutil, + link_whole: [rust_qemu_api_objs]), args: [ '--test', '--test-threads', '1', '--format', 'pretty', Until then, --enable-modules is broken together with Rust. Paolo