From: "J. Mayer" <l_indien@magic.fr>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu ./cpu-exec.c ./monitor.c target-ppc/helper...
Date: Sat, 26 Nov 2005 13:51:56 +0100 [thread overview]
Message-ID: <1133009516.13313.90.camel@rapid> (raw)
In-Reply-To: <E1Ef2k4-0002rw-00@savannah.gnu.org>
On Wed, 2005-11-23 at 17:05 -0500, Fabrice Bellard wrote:
> CVSROOT: /cvsroot/qemu
> Module name: qemu
> Branch:
> Changes by: Fabrice Bellard <bellard@savannah.gnu.org> 05/11/23 22:05:28
>
> Modified files:
> . : cpu-exec.c monitor.c
> target-ppc : helper.c translate.c
>
> Log message:
> halt state support for ppc
>
> CVSWeb URLs:
> http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/cpu-exec.c.diff?tr1=1.63&tr2=1.64&r1=text&r2=text
> http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/monitor.c.diff?tr1=1.42&tr2=1.43&r1=text&r2=text
> http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/target-ppc/helper.c.diff?tr1=1.28&tr2=1.29&r1=text&r2=text
> http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/target-ppc/translate.c.diff?tr1=1.39&tr2=1.40&r1=text&r2=text
One should beware before merging this patch in its local repository.
It was rejected in the past and is broken for many reasons:
- MSR_POW bit _does not_ mean "enter halt state". It means "enable power
management".
What the PowerPC core would do when this bit is set is implementation
dependant.
For example, PowerPC 750 (the one currently emulated by Qemu targets)
will enter halt
state only if some bits in the HID0 SPR are set.
- the cpu state cannot be changed outside of the PowerPC emulation code.
Setting the MSR_POW bit to zero is buggy because we loose useful
information to decide
wether the CPU has to go back in running state (if it's really halted)
or has to ignore the
raised exception.
--
J. Mayer <l_indien@magic.fr>
Never organized
prev parent reply other threads:[~2005-11-26 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 22:05 [Qemu-devel] qemu ./cpu-exec.c ./monitor.c target-ppc/helper Fabrice Bellard
2005-11-26 12:51 ` J. Mayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133009516.13313.90.camel@rapid \
--to=l_indien@magic.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).