From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EfzXD-0008V4-2B for qemu-devel@nongnu.org; Sat, 26 Nov 2005 07:52:07 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EfzX9-0008U1-05 for qemu-devel@nongnu.org; Sat, 26 Nov 2005 07:52:05 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EfzX7-0008Tx-3O for qemu-devel@nongnu.org; Sat, 26 Nov 2005 07:52:02 -0500 Received: from [62.210.190.9] (helo=brazzaville.magic.fr) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EfzX6-0006qO-Qc for qemu-devel@nongnu.org; Sat, 26 Nov 2005 07:52:01 -0500 Received: from [192.168.0.2] (ppp-36.net-723.magic.fr [80.118.184.36]) by brazzaville.magic.fr (8.11.6/8.11.6) with ESMTP id jAQCptI23151 for ; Sat, 26 Nov 2005 13:51:56 +0100 Subject: Re: [Qemu-devel] qemu ./cpu-exec.c ./monitor.c target-ppc/helper... From: "J. Mayer" In-Reply-To: References: Content-Type: text/plain Date: Sat, 26 Nov 2005 13:51:56 +0100 Message-Id: <1133009516.13313.90.camel@rapid> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wed, 2005-11-23 at 17:05 -0500, Fabrice Bellard wrote: > CVSROOT: /cvsroot/qemu > Module name: qemu > Branch: > Changes by: Fabrice Bellard 05/11/23 22:05:28 > > Modified files: > . : cpu-exec.c monitor.c > target-ppc : helper.c translate.c > > Log message: > halt state support for ppc > > CVSWeb URLs: > http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/cpu-exec.c.diff?tr1=1.63&tr2=1.64&r1=text&r2=text > http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/monitor.c.diff?tr1=1.42&tr2=1.43&r1=text&r2=text > http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/target-ppc/helper.c.diff?tr1=1.28&tr2=1.29&r1=text&r2=text > http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/target-ppc/translate.c.diff?tr1=1.39&tr2=1.40&r1=text&r2=text One should beware before merging this patch in its local repository. It was rejected in the past and is broken for many reasons: - MSR_POW bit _does not_ mean "enter halt state". It means "enable power management". What the PowerPC core would do when this bit is set is implementation dependant. For example, PowerPC 750 (the one currently emulated by Qemu targets) will enter halt state only if some bits in the HID0 SPR are set. - the cpu state cannot be changed outside of the PowerPC emulation code. Setting the MSR_POW bit to zero is buggy because we loose useful information to decide wether the CPU has to go back in running state (if it's really halted) or has to ignore the raised exception. -- J. Mayer Never organized