From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1VLO-0005Uy-Mh for qemu-devel@nongnu.org; Mon, 09 Oct 2017 06:31:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1VLI-0005wm-OP for qemu-devel@nongnu.org; Mon, 09 Oct 2017 06:31:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37272) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e1VLI-0005vM-Eo for qemu-devel@nongnu.org; Mon, 09 Oct 2017 06:31:24 -0400 Date: Mon, 9 Oct 2017 06:31:17 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1138849410.27888094.1507545077979.JavaMail.zimbra@redhat.com> In-Reply-To: <87wp48xkkf.fsf@dusky.pond.sub.org> References: <20170913132417.24384-1-david@redhat.com> <20170913132417.24384-19-david@redhat.com> <87k20eq9em.fsf@dusky.pond.sub.org> <20171004100415.0f0ded10.cohuck@redhat.com> <87k20bm6cw.fsf@dusky.pond.sub.org> <20171004150956.0901d6c1.cohuck@redhat.com> <87wp48xkkf.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 18/22] s390x: implement query-hotpluggable-cpus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Cornelia Huck , Matthew Rosato , thuth@redhat.com, Eduardo Habkost , David Hildenbrand , Richard Henderson , qemu-devel@nongnu.org, Alexander Graf , borntraeger@de.ibm.com, Igor Mammedov , Paolo Bonzini Hi ----- Original Message ----- > Cornelia Huck writes: >=20 > > On Wed, 04 Oct 2017 14:42:55 +0200 > > Markus Armbruster wrote: > > > >> Cornelia Huck writes: > >>=20 > >> > On Mon, 02 Oct 2017 09:46:41 +0200 > >> > Markus Armbruster wrote: > >> > =20 > >> >> David Hildenbrand writes: > >> >> =20 > >> >> > CPU hotplug is only possible on a per core basis on s390x. So let= 's > >> >> > add possible_cpus and properly wire everything up. > >> >> > > >> >> > Signed-off-by: David Hildenbrand > >> >> [...] > >> >> > diff --git a/qapi-schema.json b/qapi-schema.json > >> >> > index f3af2cb851..79e9f85404 100644 > >> >> > --- a/qapi-schema.json > >> >> > +++ b/qapi-schema.json > >> >> > @@ -3121,6 +3121,22 @@ > >> >> > # } > >> >> > # ]} > >> >> > # > >> >> > +# For s390x-virtio-ccw machine type started with -smp 1,maxcpus= =3D2 > >> >> > -cpu qemu > >> >> > +# (Since: 2.11): > >> >> > +# > >> >> > +# -> { "execute": "query-hotpluggable-cpus" } > >> >> > +# <- {"return": [ > >> >> > +# { > >> >> > +# "type": "qemu-s390-cpu", "vcpus-count": 1, > >> >> > +# "props": { "core-id": 1 } > >> >> > +# }, > >> >> > +# { > >> >> > +# "qom-path": "/machine/unattached/device[0]", > >> >> > +# "type": "qemu-s390-cpu", "vcpus-count": 1, > >> >> > +# "props": { "core-id": 0 } > >> >> > +# } > >> >> > +# ]} > >> >> > +# > >> >> > ## > >> >> > { 'command': 'query-hotpluggable-cpus', 'returns': > >> >> > ['HotpluggableCPU'] } > >> >>=20 > >> >> Please stick in '# Example:' like we do in query-hotpluggable-cpus'= s > >> >> doc > >> >> comment. I expect the generated documentation to be illegible[*] > >> >> without it. > >> > > >> > Should '# Example:' go before each of the examples (instead of the > >> > beginning of the example block), then? > >>=20 > >> Whatever makes the generated documentation look better. > > > > The pdf indeed looks ugly, but that's a preexisting problem, and adding > > more '# Example:' lines does not really help. > > > > The basic issue is that the code expects just one example and no > > additional text for the '# Example:' tag -- the explaining text for the > > various statements ends up looking like the qmp examples. That should > > be improved before doing a patch on top for this command (and I don't > > really have the skills or time to improve the output, sorry.) >=20 > Marc-Andr=C3=A9, any ideas? >=20 It's not supported atm. The ideas to fix this are pretty much a matter of t= aste. I'd suggest to keep the code below the Example: section as @example/verbati= m by default. And introduce a new section syntax, like Example:: to do "man= ual" formatting. Example:: This text would be in regular format. 1. and allow list, *strong* etc. | -> { then have some code } | <- ... And regulat text again.