qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>, Laurent Vivier <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [PATCH] linux-user/elfload: Fix pr_pid values in core files
Date: Fri, 2 Aug 2024 07:45:42 +1000	[thread overview]
Message-ID: <113a8d28-006c-4ab7-b66c-666c4cc52dde@linaro.org> (raw)
In-Reply-To: <20240801202340.21845-1-iii@linux.ibm.com>

On 8/2/24 06:23, Ilya Leoshkevich wrote:
> Analyzing qemu-produced core dumps of multi-threaded apps runs into:
> 
>      (gdb) info threads
>        [...]
>        21   Thread 0x3ff83cc0740 (LWP 9295) warning: Couldn't find general-purpose registers in core file.
>      <unavailable> in ?? ()
> 
> The reason is that all pr_pid values are the same, because the same
> TaskState is used for all CPUs when generating NT_PRSTATUS notes.
> 
> Fix by using TaskStates associated with individual CPUs.
> 
> Cc:qemu-stable@nongnu.org
> Fixes: 243c47066253 ("linux-user/elfload: Write corefile elf header in one block")
> Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com>
> ---
>   linux-user/elfload.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)

Oops,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


  reply	other threads:[~2024-08-01 21:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-01 20:23 [PATCH] linux-user/elfload: Fix pr_pid values in core files Ilya Leoshkevich
2024-08-01 21:45 ` Richard Henderson [this message]
2024-08-02 13:20 ` Philippe Mathieu-Daudé
2024-08-02 13:23   ` Ilya Leoshkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=113a8d28-006c-4ab7-b66c-666c4cc52dde@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=iii@linux.ibm.com \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).