From: Laurent Vivier <lvivier@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)
Date: Mon, 11 Sep 2017 15:17:36 +0200 [thread overview]
Message-ID: <113b2d22-73e4-b0ff-e879-c2fb223b2f35@redhat.com> (raw)
In-Reply-To: <20170911134158.1f046176.cohuck@redhat.com>
On 11/09/2017 13:41, Cornelia Huck wrote:
> On Mon, 11 Sep 2017 12:06:15 +0100
> "Daniel P. Berrange" <berrange@redhat.com> wrote:
>
>> On Mon, Sep 11, 2017 at 01:00:37PM +0200, Laurent Vivier wrote:
>>> Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault)
>>> fixes the problem for i386, do the same for ppc.
>>
>> What about all the other targets QEMU supports ? Have you checked if they
>> are similarly affected, as we don't want to wait another 6 months to get a
>> bug report that s390 or aarch64 crash in exactly the same way too.
>
> This patch actually prompted me to check s390, and the mentioned
> command line works fine.
>
> However, if we start a qemu with no guest memory defined and then call
> dump-guest-memory without filtering, we get a core dump instead of a
> guest dump (s390x or x86_64, machine none).
>
> I can take a stab at fixing that, unless someone beats me to it.
>
I will update the test with this test case too.
Thanks,
Laurent
next prev parent reply other threads:[~2017-09-11 13:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 11:00 [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc) Laurent Vivier
2017-09-11 11:06 ` Daniel P. Berrange
2017-09-11 11:20 ` Laurent Vivier
2017-09-11 11:41 ` Cornelia Huck
2017-09-11 11:43 ` Daniel P. Berrange
2017-09-11 12:04 ` Dr. David Alan Gilbert
2017-09-11 12:10 ` Laurent Vivier
2017-09-11 12:13 ` Daniel P. Berrange
2017-09-11 12:15 ` Laurent Vivier
2017-09-11 14:39 ` Thomas Huth
2017-09-11 12:21 ` Cornelia Huck
2017-09-11 13:17 ` Laurent Vivier [this message]
2017-09-11 11:14 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-09-11 14:36 ` [Qemu-devel] " Thomas Huth
2017-09-12 4:52 ` Miroslav Rezanina
2017-09-12 5:19 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=113b2d22-73e4-b0ff-e879-c2fb223b2f35@redhat.com \
--to=lvivier@redhat.com \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).