Re: [Qemu-devel] [PATCH v6 04/10] qemu.py: Simplify QMP key-conversion

[Cleber Rosa <crosa@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]



On 08/18/2017 10:26 AM, Lukáš Doktor wrote:
> The QMP key conversion consist of '_'s to be replaced with '-'s, which
> can easily be done by a single `str.replace` method which is faster and
> does not require `string` module import.
> 
> Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  scripts/qemu.py | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index db21407..19cbd34 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -13,7 +13,6 @@
>  #
>  
>  import errno
> -import string
>  import os
>  import sys
>  import subprocess
> @@ -181,14 +180,12 @@ class QEMUMachine(object):
>              self._load_io_log()
>              self._post_shutdown()
>  
> -    underscore_to_dash = string.maketrans('_', '-')
> -
>      def qmp(self, cmd, conv_keys=True, **args):
>          '''Invoke a QMP command and return the response dict'''
>          qmp_args = dict()
>          for key, value in args.iteritems():
>              if conv_keys:
> -                qmp_args[key.translate(self.underscore_to_dash)] = value
> +                qmp_args[key.replace('_', '-')] = value
>              else:
>                  qmp_args[key] = value
>  
> 

Right, this would only make sense if multiple (different) substitutions
were necessary.

Reviewed-by: Cleber Rosa <crosa@redhat.com>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]