From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPBc3-0005WF-PF for qemu-devel@nongnu.org; Mon, 18 Jul 2016 12:41:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPBbz-0006wb-ER for qemu-devel@nongnu.org; Mon, 18 Jul 2016 12:41:46 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:53252) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPBbz-0006vy-6T for qemu-devel@nongnu.org; Mon, 18 Jul 2016 12:41:43 -0400 Date: Mon, 18 Jul 2016 12:41:40 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1142506826.6113878.1468860100085.JavaMail.zimbra@redhat.com> In-Reply-To: <1891660984.6191632.1468590970091.JavaMail.zimbra@redhat.com> References: <1468590577-30914-1-git-send-email-fziglio@redhat.com> <1468590577-30914-2-git-send-email-fziglio@redhat.com> <1891660984.6191632.1468590970091.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Spice-devel] [PATCH Qemu] Change spice-server protocol for GL texture passing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Frediano Ziglio Cc: spice-devel@lists.freedesktop.org, Qemu-devel , Gerd Hoffmann Hi ----- Original Message ----- > Forgot to add RFC to the subject > What's the rationale? if you share the texture id, you must share the GL context too, right? Why not use a lower level dmabuf fd that can be imported by the server gl context (which is also what the protocol require anyway)? > > > > > --- > > ui/spice-core.c | 5 ----- > > ui/spice-display.c | 29 ++++++++--------------------- > > 2 files changed, 8 insertions(+), 26 deletions(-) > > > > diff --git a/ui/spice-core.c b/ui/spice-core.c > > index da05054..f7647f7 100644 > > --- a/ui/spice-core.c > > +++ b/ui/spice-core.c > > @@ -828,11 +828,6 @@ void qemu_spice_init(void) > > > > #ifdef HAVE_SPICE_GL > > if (qemu_opt_get_bool(opts, "gl", 0)) { > > - if ((port != 0) || (tls_port != 0)) { > > - error_report("SPICE GL support is local-only for now and " > > - "incompatible with -spice port/tls-port"); > > - exit(1); > > - } > > if (egl_rendernode_init() != 0) { > > error_report("Failed to initialize EGL render node for SPICE > > GL"); > > exit(1); > > diff --git a/ui/spice-display.c b/ui/spice-display.c > > index 2a77a54..72137bd 100644 > > --- a/ui/spice-display.c > > +++ b/ui/spice-display.c > > @@ -852,6 +852,10 @@ static void qemu_spice_gl_block_timer(void *opaque) > > static QEMUGLContext qemu_spice_gl_create_context(DisplayChangeListener > > *dcl, > > QEMUGLParams *params) > > { > > + SimpleSpiceDisplay *ssd = container_of(dcl, SimpleSpiceDisplay, dcl); > > + > > + spice_qxl_gl_init(&ssd->qxl, qemu_egl_display, qemu_egl_rn_ctx); > > + > > eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE, EGL_NO_SURFACE, > > qemu_egl_rn_ctx); > > return qemu_egl_create_context(dcl, params); > > @@ -864,28 +868,11 @@ static void > > qemu_spice_gl_scanout(DisplayChangeListener > > *dcl, > > uint32_t w, uint32_t h) > > { > > SimpleSpiceDisplay *ssd = container_of(dcl, SimpleSpiceDisplay, dcl); > > - EGLint stride = 0, fourcc = 0; > > - int fd = -1; > > - > > - if (tex_id) { > > - fd = egl_get_fd_for_texture(tex_id, &stride, &fourcc); > > - if (fd < 0) { > > - fprintf(stderr, "%s: failed to get fd for texture\n", > > __func__); > > - return; > > - } > > - dprint(1, "%s: %dx%d (stride %d, fourcc 0x%x)\n", __func__, > > - w, h, stride, fourcc); > > - } else { > > - dprint(1, "%s: no texture (no framebuffer)\n", __func__); > > - } > > - > > - assert(!tex_id || fd >= 0); > > > > - /* note: spice server will close the fd */ > > - spice_qxl_gl_scanout(&ssd->qxl, fd, > > - surface_width(ssd->ds), > > - surface_height(ssd->ds), > > - stride, fourcc, y_0_top); > > + spice_qxl_gl_scanout_texture(&ssd->qxl, tex_id, > > + surface_width(ssd->ds), > > + surface_height(ssd->ds), > > + y_0_top); > > > > qemu_spice_gl_monitor_config(ssd, x, y, w, h); > > } > _______________________________________________ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel >