qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <mlureau@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] config: enable ivshmem on POSIX
Date: Mon, 12 Oct 2015 12:05:08 -0400 (EDT)	[thread overview]
Message-ID: <1148374065.29038720.1444665908658.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAFEAcA_eN2Uz-saBR_N6C9DNfRHUoD8c1PvBqmjA0zyCZhXbUQ@mail.gmail.com>

Hi Peter

----- Original Message -----
> On 12 October 2015 at 16:12,  <marcandre.lureau@redhat.com> wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > ivshmem doesn't actually require kvm, so enable it when POSIX is
> > enabled. (it is required however when ioeventfd is enabled)
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> >  default-configs/pci.mak | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/default-configs/pci.mak b/default-configs/pci.mak
> > index 7e10903..f250119 100644
> > --- a/default-configs/pci.mak
> > +++ b/default-configs/pci.mak
> > @@ -35,5 +35,5 @@ CONFIG_SDHCI=y
> >  CONFIG_EDU=y
> >  CONFIG_VGA=y
> >  CONFIG_VGA_PCI=y
> > -CONFIG_IVSHMEM=$(CONFIG_KVM)
> > +CONFIG_IVSHMEM=$(CONFIG_POSIX)
> >  CONFIG_ROCKER=y
> 
> I did a quick test of an OSX build with this change and
> you'll be pleased to know it builds ok, no new compile
> warnings :-)

Yes indeed, thanks for checking!

Can I add tested-by or do you add your signed off?

  reply	other threads:[~2015-10-12 16:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12 15:12 [Qemu-devel] [PATCH] config: enable ivshmem on POSIX marcandre.lureau
2015-10-12 16:01 ` Peter Maydell
2015-10-12 16:05   ` Marc-André Lureau [this message]
2015-10-12 16:19     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1148374065.29038720.1444665908658.JavaMail.zimbra@redhat.com \
    --to=mlureau@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).