From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44692)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1ZlfbD-0003HY-UG
	for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:05:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1ZlfbA-0005Yl-IL
	for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:05:19 -0400
Received: from mx6-phx2.redhat.com ([209.132.183.39]:43671)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1ZlfbA-0005YP-Bh
	for qemu-devel@nongnu.org; Mon, 12 Oct 2015 12:05:16 -0400
Date: Mon, 12 Oct 2015 12:05:08 -0400 (EDT)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <1148374065.29038720.1444665908658.JavaMail.zimbra@redhat.com>
In-Reply-To: <CAFEAcA_eN2Uz-saBR_N6C9DNfRHUoD8c1PvBqmjA0zyCZhXbUQ@mail.gmail.com>
References: <1444662732-31557-1-git-send-email-marcandre.lureau@redhat.com>
	<CAFEAcA_eN2Uz-saBR_N6C9DNfRHUoD8c1PvBqmjA0zyCZhXbUQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] config: enable ivshmem on POSIX
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, "Michael S. Tsirkin" <mst@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

Hi Peter

----- Original Message -----
> On 12 October 2015 at 16:12,  <marcandre.lureau@redhat.com> wrote:
> > From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> >
> > ivshmem doesn't actually require kvm, so enable it when POSIX is
> > enabled. (it is required however when ioeventfd is enabled)
> >
> > Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> > ---
> >  default-configs/pci.mak | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/default-configs/pci.mak b/default-configs/pci.mak
> > index 7e10903..f250119 100644
> > --- a/default-configs/pci.mak
> > +++ b/default-configs/pci.mak
> > @@ -35,5 +35,5 @@ CONFIG_SDHCI=3Dy
> >  CONFIG_EDU=3Dy
> >  CONFIG_VGA=3Dy
> >  CONFIG_VGA_PCI=3Dy
> > -CONFIG_IVSHMEM=3D$(CONFIG_KVM)
> > +CONFIG_IVSHMEM=3D$(CONFIG_POSIX)
> >  CONFIG_ROCKER=3Dy
>=20
> I did a quick test of an OSX build with this change and
> you'll be pleased to know it builds ok, no new compile
> warnings :-)

Yes indeed, thanks for checking!

Can I add tested-by or do you add your signed off?