Re: [PATCH v14 09/11] qapi/s390/cpu topology: monitor query topology information

[Thomas Huth <thuth@redhat.com>]

On 05/01/2023 15.53, Pierre Morel wrote:
> Reporting the current topology informations to the admin through
> the QEMU monitor.
> 
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
...
> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
> index 754b1e8408..5730a47f71 100644
> --- a/hmp-commands-info.hx
> +++ b/hmp-commands-info.hx
> @@ -993,3 +993,19 @@ SRST
>     ``info virtio-queue-element`` *path* *queue* [*index*]
>       Display element of a given virtio queue
>   ERST
> +
> +#if defined(TARGET_S390X) && defined(CONFIG_KVM)
> +    {
> +        .name       = "query-topology",
> +        .args_type  = "",
> +        .params     = "",
> +        .help       = "Show information about CPU topology",
> +        .cmd        = hmp_query_topology,
> +        .flags      = "p",
> +    },
> +
> +SRST
> +  ``info query-topology``

"info query-topology" sounds weird ... I'd maybe rather call it only "info 
topology" or "info cpu-topology" here.

  Thomas


> +    Show information about CPU topology
> +ERST
> +#endif