From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 01/11] hw/input/pckbd: Use qemu_log_mask(GUEST_ERROR) instead of fprintf
Date: Fri, 22 Jun 2018 10:04:10 +0200 [thread overview]
Message-ID: <114c5545-19e6-690a-78a7-4586aa57860d@redhat.com> (raw)
In-Reply-To: <20180621180224.8312-2-f4bug@amsat.org>
On 21.06.2018 20:02, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/input/pckbd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
> index f33e3fc63d..1102d2a31b 100644
> --- a/hw/input/pckbd.c
> +++ b/hw/input/pckbd.c
> @@ -22,6 +22,7 @@
> * THE SOFTWARE.
> */
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "hw/hw.h"
> #include "hw/isa/isa.h"
> #include "hw/i386/pc.h"
> @@ -308,7 +309,8 @@ static void kbd_write_command(void *opaque, hwaddr addr,
> /* ignore that */
> break;
> default:
> - fprintf(stderr, "qemu: unsupported keyboard cmd=0x%02x\n", (int)val);
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "qemu: unsupported keyboard cmd=0x%02lx\n", val);
Please remove the "qemu:" prefix while you're at it.
Thomas
next prev parent reply other threads:[~2018-06-22 8:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 18:02 [Qemu-devel] [PATCH 00/11] hw/arm: use qemu_log_mask instead of fprintf Philippe Mathieu-Daudé
2018-06-21 18:02 ` [Qemu-devel] [PATCH 01/11] hw/input/pckbd: Use qemu_log_mask(GUEST_ERROR) " Philippe Mathieu-Daudé
2018-06-22 8:04 ` Thomas Huth [this message]
2018-06-22 13:19 ` Philippe Mathieu-Daudé
2018-06-21 18:02 ` [Qemu-devel] [PATCH 03/11] hw/dma/omap_dma: Use qemu_log_mask(UNIMP) instead of printf Philippe Mathieu-Daudé
2018-06-22 8:11 ` Thomas Huth
2018-06-21 18:02 ` [Qemu-devel] [PATCH 04/11] hw/dma/omap_dma: Use qemu_log_mask(GUEST_ERROR) instead of fprintf Philippe Mathieu-Daudé
2018-06-22 8:24 ` Thomas Huth
2018-06-22 13:23 ` Philippe Mathieu-Daudé
2018-06-21 18:02 ` [Qemu-devel] [PATCH 05/11] hw/ssi/omap_spi: " Philippe Mathieu-Daudé
2018-06-21 18:04 ` Alistair Francis
2018-06-21 18:02 ` [Qemu-devel] [PATCH 06/11] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf Philippe Mathieu-Daudé
2018-06-22 8:26 ` Thomas Huth
2018-06-21 18:02 ` [Qemu-devel] [PATCH 07/11] hw/i2c/omap_i2c: Use qemu_log_mask(UNIMP) instead of fprintf Philippe Mathieu-Daudé
2018-06-22 8:29 ` Thomas Huth
2018-06-21 18:02 ` [Qemu-devel] [PATCH 08/11] hw/arm/omap: Use qemu_log_mask(GUEST_ERROR) " Philippe Mathieu-Daudé
2018-06-22 8:34 ` Thomas Huth
2018-06-22 13:23 ` Philippe Mathieu-Daudé
2018-06-21 18:02 ` [Qemu-devel] [PATCH 09/11] hw/arm/stellaris: Use qemu_log_mask(UNIMP) " Philippe Mathieu-Daudé
2018-06-22 8:36 ` Thomas Huth
2018-06-21 18:02 ` [Qemu-devel] [PATCH 10/11] hw/net/stellaris_enet: Use qemu_log_mask(GUEST_ERROR) instead of hw_error Philippe Mathieu-Daudé
2018-06-22 8:43 ` Thomas Huth
2018-06-22 13:24 ` Philippe Mathieu-Daudé
2018-06-21 18:02 ` [Qemu-devel] [PATCH 11/11] hw/net/smc91c111: " Philippe Mathieu-Daudé
2018-06-22 8:43 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=114c5545-19e6-690a-78a7-4586aa57860d@redhat.com \
--to=thuth@redhat.com \
--cc=f4bug@amsat.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).