From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45146)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1Su257-0007FY-8Z
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 09:56:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1Su256-0001qt-2v
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 09:56:53 -0400
Received: from mx3-phx2.redhat.com ([209.132.183.24]:58657)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1Su255-0001qk-Ru
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 09:56:52 -0400
Date: Wed, 25 Jul 2012 09:56:50 -0400 (EDT)
From: Amos Kong <akong@redhat.com>
Message-ID: <1154274510.2626192.1343224610605.JavaMail.root@redhat.com>
In-Reply-To: <20120725093845.72ee7b46@doriath.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, eblake@redhat.com, qemu-devel@nongnu.org

----- Original Message -----
> On Wed, 25 Jul 2012 01:55:14 -0400 (EDT)
> Amos Kong <akong@redhat.com> wrote:
>=20
> >=20
> >=20
> > ----- Original Message -----
> > > On Thu,  5 Jul 2012 20:48:44 +0800
> > > Amos Kong <akong@redhat.com> wrote:
> > >=20
> > > > Convert 'sendkey' to use QAPI. do_sendkey() depends on some
> > > > variables/functions in monitor.c, so reserve qmp_sendkey()
> > > > to monitor.c
> > > >=20
> > > > key_defs[] in console.h is the mapping of key name to keycode,
> > > > Keys' index in the enmu and key_defs[] is same.
> > > >=20
> > > > 'send-key' of QMP doesn't support key in hexadecimal format.
> > > >=20
> > > > Signed-off-by: Amos Kong <akong@redhat.com>
> > > > ---
> > > >  console.h        |  152 ++++++++++++++++++++++++++++++++++
> > > >  hmp-commands.hx  |    2 +-
> > > >  hmp.c            |   64 +++++++++++++++
> > > >  hmp.h            |    1 +
> > > >  monitor.c        |  239
> > > >  ++++++------------------------------------------------
> > > >  qapi-schema.json |   46 +++++++++++
> > > >  qmp-commands.hx  |   28 +++++++
> > > >  7 files changed, 317 insertions(+), 215 deletions(-)
> >=20
> > ...
> >=20
> > > > diff --git a/qapi-schema.json b/qapi-schema.json
> > > > index 3b6e346..08e51c6 100644
> > > > --- a/qapi-schema.json
> > > > +++ b/qapi-schema.json
> > > > @@ -1862,3 +1862,49 @@
> > > >  # Since: 0.14.0
> > > >  ##
> > > >  { 'command': 'netdev_del', 'data': {'id': 'str'} }
> > > > +
> > > > +##
> > > > +# @KeyCodes:
> > >=20
> > > s/KeyCodes/KeyCode
> >=20
> >=20
> > 'KeyCode' is not an available variable name.
> >=20
> > | ./qapi-types.h:471: error: conflicting types for =E2=80=98KeyCode=E2=
=80=99
> > | /usr/include/X11/X.h:108: note: previous declaration of =E2=80=98KeyC=
ode=E2=80=99
> > | was here
> >=20
> > How about 'CodeOfKey'?
>=20
> QKeyCode, maybe?

Looks good.

> Can you please paste the full error message?

[root@dhcp-8-167 qemu]# make=20
  ....
  CC    slirp/arp_table.o
  CC    ui/keymaps.o
  CC    ui/spice-core.o
  CC    ui/spice-input.o
  CC    ui/spice-display.o
  CC    ui/sdl.o
In file included from ./console.h:9,
                 from ui/sdl.c:32:
./qapi-types.h:471: error: conflicting types for =E2=80=98KeyCode=E2=80=99
/usr/include/X11/X.h:108: note: previous declaration of =E2=80=98KeyCode=E2=
=80=99 was here
make: *** [ui/sdl.o] Error 1
[root@dhcp-8-167 qemu]#=20