From: Levente Kurusa <lkurusa@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Cole Robinson <crobinso@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Marcel Apfelbaum <marcel.a@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] ivshmem: convert option 'use64' to a bit instead of integer
Date: Mon, 11 Aug 2014 05:26:34 -0400 (EDT) [thread overview]
Message-ID: <1155948309.13500994.1407749194182.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20140805160023.GA17384@redhat.com>
> On Mon, Aug 04, 2014 at 05:06:21PM +0200, Levente Kurusa wrote:
> > It was expecting an integer, however the sole usecase of it just
> > checked whether it was assigned to or not. Hence, remove integerness,
> > and add a new bitfield instead.
> >
> > Signed-off-by: Levente Kurusa <lkurusa@redhat.com>
>
> This might break some existing scripts.
> If you want to address this, add a new type that
> can accept both integer and bool.
Yea, makes sense.
I don't really know whether adding a new type is worth the effort;
let's just drop this patch and keep the interface as it is, since it
makes no harm.
Should I resend the first patch as a separate patch or can it be
applied as it is?
Oh, and are we taking the ivshmem command line as set in stone?
I'm asking because I don't really see the point in that, given that
ivshmem is still experimental and broken in many cases.
Thanks,
Levente Kurusa
prev parent reply other threads:[~2014-08-11 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 15:06 [Qemu-devel] [PATCH 0/2] ivshmem: clean up building and arguments Levente Kurusa
2014-08-04 15:06 ` [Qemu-devel] [PATCH 1/2] ivshmem: fix building when debug mode is enabled Levente Kurusa
2014-08-04 15:06 ` [Qemu-devel] [PATCH 2/2] ivshmem: convert option 'use64' to a bit instead of integer Levente Kurusa
2014-08-05 16:00 ` Michael S. Tsirkin
2014-08-11 9:26 ` Levente Kurusa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1155948309.13500994.1407749194182.JavaMail.zimbra@redhat.com \
--to=lkurusa@redhat.com \
--cc=crobinso@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).