From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55855)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lkurusa@redhat.com>) id 1XGlsI-0003KZ-3q
	for qemu-devel@nongnu.org; Mon, 11 Aug 2014 05:26:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lkurusa@redhat.com>) id 1XGlsB-0001hf-VD
	for qemu-devel@nongnu.org; Mon, 11 Aug 2014 05:26:42 -0400
Received: from mx4-phx2.redhat.com ([209.132.183.25]:37622)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lkurusa@redhat.com>) id 1XGlsB-0001gm-NG
	for qemu-devel@nongnu.org; Mon, 11 Aug 2014 05:26:35 -0400
Date: Mon, 11 Aug 2014 05:26:34 -0400 (EDT)
From: Levente Kurusa <lkurusa@redhat.com>
Message-ID: <1155948309.13500994.1407749194182.JavaMail.zimbra@redhat.com>
In-Reply-To: <20140805160023.GA17384@redhat.com>
References: <1407164781-32486-1-git-send-email-lkurusa@redhat.com>
	<1407164781-32486-3-git-send-email-lkurusa@redhat.com>
	<20140805160023.GA17384@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] ivshmem: convert option 'use64' to a
 bit instead of integer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Cole Robinson <crobinso@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Marcel Apfelbaum <marcel.a@redhat.com>

> On Mon, Aug 04, 2014 at 05:06:21PM +0200, Levente Kurusa wrote:
> > It was expecting an integer, however the sole usecase of it just
> > checked whether it was assigned to or not. Hence, remove integerness,
> > and add a new bitfield instead.
> > 
> > Signed-off-by: Levente Kurusa <lkurusa@redhat.com>
> 
> This might break some existing scripts.
> If you want to address this, add a new type that
> can accept both integer and bool.

Yea, makes sense.

I don't really know whether adding a new type is worth the effort;
let's just drop this patch and keep the interface as it is, since it
makes no harm.

Should I resend the first patch as a separate patch or can it be
applied as it is?

Oh, and are we taking the ivshmem command line as set in stone?
I'm asking because I don't really see the point in that, given that
ivshmem is still experimental and broken in many cases.

Thanks,
Levente Kurusa