* [Qemu-devel] [PATCH] Don't include <linux/compiler.h>
@ 2006-09-11 7:23 David Woodhouse
2006-09-11 20:13 ` Fabrice Bellard
0 siblings, 1 reply; 3+ messages in thread
From: David Woodhouse @ 2006-09-11 7:23 UTC (permalink / raw)
To: qemu-devel
This file is not one of the kernel headers which is exported to
userspace by the kernel. It should not exist in /usr/include/linux and
certainly shouldn't be included by userspace programs.
diff -Naupr qemu-0.8.2.orig/usb-linux.c qemu-0.8.2/usb-linux.c
--- qemu-0.8.2.orig/usb-linux.c 2006-07-22 19:23:34.000000000 +0200
+++ qemu-0.8.2/usb-linux.c 2006-08-23 18:47:16.000000000 +0200
@@ -26,7 +26,6 @@
#if defined(__linux__)
#include <dirent.h>
#include <sys/ioctl.h>
-#include <linux/compiler.h>
#include <linux/usbdevice_fs.h>
#include <linux/version.h>
--
dwmw2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Don't include <linux/compiler.h>
2006-09-11 7:23 [Qemu-devel] [PATCH] Don't include <linux/compiler.h> David Woodhouse
@ 2006-09-11 20:13 ` Fabrice Bellard
2006-09-11 21:33 ` David Woodhouse
0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Bellard @ 2006-09-11 20:13 UTC (permalink / raw)
To: dwmw2; +Cc: qemu-devel
The problem is that without this header it does not compile on some
distributions (see old mailing list messages).
Fabrice.
David Woodhouse wrote:
> This file is not one of the kernel headers which is exported to
> userspace by the kernel. It should not exist in /usr/include/linux and
> certainly shouldn't be included by userspace programs.
>
> diff -Naupr qemu-0.8.2.orig/usb-linux.c qemu-0.8.2/usb-linux.c
> --- qemu-0.8.2.orig/usb-linux.c 2006-07-22 19:23:34.000000000 +0200
> +++ qemu-0.8.2/usb-linux.c 2006-08-23 18:47:16.000000000 +0200
> @@ -26,7 +26,6 @@
> #if defined(__linux__)
> #include <dirent.h>
> #include <sys/ioctl.h>
> -#include <linux/compiler.h>
> #include <linux/usbdevice_fs.h>
> #include <linux/version.h>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Don't include <linux/compiler.h>
2006-09-11 20:13 ` Fabrice Bellard
@ 2006-09-11 21:33 ` David Woodhouse
0 siblings, 0 replies; 3+ messages in thread
From: David Woodhouse @ 2006-09-11 21:33 UTC (permalink / raw)
To: Fabrice Bellard; +Cc: qemu-devel
On Mon, 2006-09-11 at 22:13 +0200, Fabrice Bellard wrote:
> The problem is that without this header it does not compile on some
> distributions (see old mailing list messages).
And the problem is that _with_ it, it doesn't compile with the proper
exported kernel headers from current kernels -- where <linux/compiler.h>
does not exist.
--
dwmw2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-11 21:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-11 7:23 [Qemu-devel] [PATCH] Don't include <linux/compiler.h> David Woodhouse
2006-09-11 20:13 ` Fabrice Bellard
2006-09-11 21:33 ` David Woodhouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).