From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34254)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pkalever@redhat.com>) id 1ZfhOh-0002uz-Lj
	for qemu-devel@nongnu.org; Sat, 26 Sep 2015 00:47:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pkalever@redhat.com>) id 1ZfhOe-00049D-FI
	for qemu-devel@nongnu.org; Sat, 26 Sep 2015 00:47:43 -0400
Received: from mx3-phx2.redhat.com ([209.132.183.24]:41567)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pkalever@redhat.com>) id 1ZfhOe-00048I-7d
	for qemu-devel@nongnu.org; Sat, 26 Sep 2015 00:47:40 -0400
Date: Sat, 26 Sep 2015 00:47:34 -0400 (EDT)
From: Prasanna Kalever <pkalever@redhat.com>
Message-ID: <1159167986.22189489.1443242854311.JavaMail.zimbra@redhat.com>
In-Reply-To: <20150923150455.GL324088@andariel.pipo.sk>
References: <1442834654-28198-1-git-send-email-prasanna.kalever@redhat.com>
	<56002543.9040908@redhat.com>
	<931442464.19730275.1442909214144.JavaMail.zimbra@redhat.com>
	<20150923150455.GL324088@andariel.pipo.sk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/1] block/gluster: add support for
 multiple gluster backup volfile servers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Krempa <pkrempa@redhat.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, deepakcs@redhat.com, bharata@linux.vnet.ibm.com, rtalur@redhat.com

> On Tue, Sep 22, 2015 at 04:06:54 -0400, Prasanna Kalever wrote:
> > 
> > > On 09/21/2015 05:24 AM, Prasanna Kumar Kalever wrote:
> > > > This patch adds a way to specify multiple backup volfile servers to the
> > > > gluster
> > > > block backend of QEMU with tcp|rdma transport types and their port
> > > > numbers.
> > > > 
> > > 
> ter
> ...
> 
> > 
> > > > +##
> > > > +{ 'struct': 'BlockdevOptionsGluster',
> > > > +  'data': { 'volname': 'str',
> > > > +            'image-path': 'str',
> > > > +            'backup-volfile-servers': [ 'GlusterTuplePattern' ] } }
> > > 
> > > Shouldn't this be simply 'volfile-servers', as you are including the
> > > primary server in addition to the backup servers?
> > >
> > 
> > Again I want to maintain naming as mount.glusterfs do for fuse.
> 
> Well, I have to agree with Eric here. I think the option name doesn't
> need to be kept in sync with the gluster implementation since they don't
> share anything with qemu and since the array contains also the primary
> server to be queried the word backup doesn't make snese there.

Yes Peter, I have to agree with you and Eric.
I will rectify this changes in next patch-set, just waiting for 'gfapi' patch to get merged.

Thank you,

Best Regards, 
Prasanna Kumar Kalever.

> 
> Peter
>