From: Ulrich Obergfell <uobergfe@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org,
kvm <kvm@vger.kernel.org>,
gcosta@redhat.com
Subject: [Qemu-devel] Re: [PATCH 1/3] alleviate time drift with HPET periodic timers
Date: Tue, 22 Mar 2011 05:40:21 -0400 (EDT) [thread overview]
Message-ID: <1170032862.455751.1300786821647.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <4D847B1D.3000002@web.de>
>> Part 1 of the patch implements the following QEMU command line option.
>>
>> -hpet [device=none|present][,driftfix=none|slew]
>
> Just define driftfix as property of the hpet device. That way it can be
> controlled both globally (-global hpet.driftfix=...) and per hpet block
> (once we support instantiating >1 of them).
Many Thanks Jan,
I started investigating code changes. I'm thinking of ...
- adding a new field to the HPETState structure.
uint32_t driftfix;
- adding the property 'driftfix' to the DeviceInfo structure.
DEFINE_PROP_BIT("driftfix", HPETState, driftfix, 0, false)
Using a single bit so that the option syntax would be, e.g.:
-global hpet.driftfix=on (Default is 'off')
- Replace all 'if (hpet_driftfix ...)' by:
if ((HPETState)s->driftfix ...)
Regards,
Uli
prev parent reply other threads:[~2011-03-22 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <739175196.420885.1300461195339.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2011-03-18 15:54 ` [Qemu-devel] [PATCH 1/3] alleviate time drift with HPET periodic timers Ulrich Obergfell
2011-03-19 9:45 ` [Qemu-devel] " Jan Kiszka
2011-03-22 9:40 ` Ulrich Obergfell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1170032862.455751.1300786821647.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com \
--to=uobergfe@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=gcosta@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).