From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8lJO-00043p-2x for qemu-devel@nongnu.org; Thu, 11 May 2017 06:27:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8lJK-0006Bx-Vk for qemu-devel@nongnu.org; Thu, 11 May 2017 06:27:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55886) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d8lJK-0006Bb-MY for qemu-devel@nongnu.org; Thu, 11 May 2017 06:27:06 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CAEB080F98 for ; Thu, 11 May 2017 10:27:05 +0000 (UTC) Date: Thu, 11 May 2017 06:27:03 -0400 (EDT) From: Marcel Apfelbaum Message-ID: <1170982462.6718936.1494498423634.JavaMail.zimbra@redhat.com> In-Reply-To: <20170511102529.21618-1-marcel@redhat.com> References: <20170511102529.21618-1-marcel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2] Revert "hw/pci: disable pci-bridge's shpc by default" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mst@redhat.com, pbonzini@redhat.com, lersek@redhat.com, dgilbert@redhat.com ----- Original Message ----- > From: "Marcel Apfelbaum" > To: qemu-devel@nongnu.org > Cc: marcel@redhat.com, mst@redhat.com, pbonzini@redhat.com, lersek@redhat.com, dgilbert@redhat.com > Sent: Thursday, May 11, 2017 1:25:29 PM > Subject: [Qemu-devel] [PATCH V2] Revert "hw/pci: disable pci-bridge's shpc by default" > > This reverts commit dc0ae767700c156894e36fab89a745a2dc4173de. > > Disabling the shpc controller has an undesired side effect. > The PCI bridge remains with no attached devices at boot time, > and the guest operating systems do not allocate any resources > for it, leaving the bridge unusable. Note that the behaviour > is dictated by the pci bridge specification. > > Revert the commit and leave the shpc controller even if is not > actually used by any architecture. Slot 0 remains unusable at boot time. > > Keep shpc off for QEMU 2.9 machines. > > Signed-off-by: Marcel Apfelbaum > --- > > V1 -> V2: > - Keep shpc off for QEMU 2.9 machines Forgot to mentioned the above was Paolo's review, thanks Palo! Marcel > - Rebased on Michael's tree to get QEMU 2.10 machine types > > Thanks, > Marcel > > hw/pci-bridge/pci_bridge_dev.c | 2 +- > include/hw/compat.h | 6 +++++- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c > index 647ad80..5dbd933 100644 > --- a/hw/pci-bridge/pci_bridge_dev.c > +++ b/hw/pci-bridge/pci_bridge_dev.c > @@ -163,7 +163,7 @@ static Property pci_bridge_dev_properties[] = { > DEFINE_PROP_ON_OFF_AUTO(PCI_BRIDGE_DEV_PROP_MSI, PCIBridgeDev, msi, > ON_OFF_AUTO_AUTO), > DEFINE_PROP_BIT(PCI_BRIDGE_DEV_PROP_SHPC, PCIBridgeDev, flags, > - PCI_BRIDGE_DEV_F_SHPC_REQ, false), > + PCI_BRIDGE_DEV_F_SHPC_REQ, true), > DEFINE_PROP_END_OF_LIST(), > }; > > diff --git a/include/hw/compat.h b/include/hw/compat.h > index 846b90e..55b1765 100644 > --- a/include/hw/compat.h > +++ b/include/hw/compat.h > @@ -2,7 +2,11 @@ > #define HW_COMPAT_H > > #define HW_COMPAT_2_9 \ > - /* empty */ > + {\ > + .driver = "pci-bridge",\ > + .property = "shpc",\ > + .value = "off",\ > + }, > > #define HW_COMPAT_2_8 \ > {\ > -- > 2.9.3 > >