From: Jocelyn Mayer <l_indien@magic.fr>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu vl.h hw/pckbd.c
Date: Mon, 16 Apr 2007 19:36:18 +0200 [thread overview]
Message-ID: <1176744978.3377.18.camel@jma4.dev.netgem.com> (raw)
In-Reply-To: <E1HdUsi-0002jo-BE@cvs>
On Mon, 2007-04-16 at 17:20 +0000, Thiemo Seufer wrote:
> CVSROOT: /sources/qemu
> Module name: qemu
> Changes by: Thiemo Seufer <ths> 07/04/16 17:20:48
>
> Modified files:
> . : vl.h
> hw : pckbd.c
>
> Log message:
> Memory-mapped interface for PS/2 controller, by Herve Poussineau.
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/vl.h?cvsroot=qemu&r1=1.210&r2=1.211
> http://cvs.savannah.gnu.org/viewcvs/qemu/hw/pckbd.c?cvsroot=qemu&r1=1.18&r2=1.19
Hi,
This patch is incorrect:
- it does make use of the it_shift parameter
- it does not properly handle word and long accesses.
The patch for the RTC is also incorrect:
- it does not have a it_shift parameter
- it does not handle the target endianness.
I've got a correct patch for the memory mapped keyboard, as used on some
PowerPC boards. I'll commit it soon. Please take a look to fix the RTC
issues.
prev parent reply other threads:[~2007-04-16 17:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-16 17:20 [Qemu-devel] qemu vl.h hw/pckbd.c Thiemo Seufer
2007-04-16 17:36 ` Jocelyn Mayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176744978.3377.18.camel@jma4.dev.netgem.com \
--to=l_indien@magic.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).