From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HdVCT-0001fj-O3
	for qemu-devel@nongnu.org; Mon, 16 Apr 2007 13:41:13 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HdVCS-0001cy-6P
	for qemu-devel@nongnu.org; Mon, 16 Apr 2007 13:41:13 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HdVCR-0001cf-W7
	for qemu-devel@nongnu.org; Mon, 16 Apr 2007 13:41:12 -0400
Received: from honiara.magic.fr ([195.154.193.36])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <l_indien@magic.fr>) id 1HdV7o-0005L7-55
	for qemu-devel@nongnu.org; Mon, 16 Apr 2007 13:36:24 -0400
Received: from [172.17.17.137] (gw.netgem.com [195.68.2.34])
	by honiara.magic.fr (8.13.1/8.13.1) with ESMTP id l3GHaI8T024925
	for <qemu-devel@nongnu.org>; Mon, 16 Apr 2007 19:36:21 +0200
Subject: Re: [Qemu-devel] qemu vl.h hw/pckbd.c
From: Jocelyn Mayer <l_indien@magic.fr>
In-Reply-To: <E1HdUsi-0002jo-BE@cvs>
References: <E1HdUsi-0002jo-BE@cvs>
Content-Type: text/plain
Date: Mon, 16 Apr 2007 19:36:18 +0200
Message-Id: <1176744978.3377.18.camel@jma4.dev.netgem.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: l_indien@magic.fr, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Mon, 2007-04-16 at 17:20 +0000, Thiemo Seufer wrote:
> CVSROOT:	/sources/qemu
> Module name:	qemu
> Changes by:	Thiemo Seufer <ths>	07/04/16 17:20:48
> 
> Modified files:
> 	.              : vl.h 
> 	hw             : pckbd.c 
> 
> Log message:
> 	Memory-mapped interface for PS/2 controller, by Herve Poussineau.
> 
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/vl.h?cvsroot=qemu&r1=1.210&r2=1.211
> http://cvs.savannah.gnu.org/viewcvs/qemu/hw/pckbd.c?cvsroot=qemu&r1=1.18&r2=1.19

Hi,

This patch is incorrect:
- it does make use of the it_shift parameter
- it does not properly handle word and long accesses.

The patch for the RTC is also incorrect:
- it does not have a it_shift parameter
- it does not handle the target endianness.

I've got a correct patch for the memory mapped keyboard, as used on some
PowerPC boards. I'll commit it soon. Please take a look to fix the RTC
issues.