From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HeF49-0004b0-NS for qemu-devel@nongnu.org; Wed, 18 Apr 2007 14:39:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HeF48-0004ao-0G for qemu-devel@nongnu.org; Wed, 18 Apr 2007 14:39:41 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HeF47-0004al-Tz for qemu-devel@nongnu.org; Wed, 18 Apr 2007 14:39:39 -0400 Received: from bangui.magic.fr ([195.154.194.245]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HeEzF-0008WD-RS for qemu-devel@nongnu.org; Wed, 18 Apr 2007 14:34:38 -0400 Received: from [192.168.0.2] (ppp-36.net-723.magic.fr [80.118.184.36]) by bangui.magic.fr (8.13.1/8.13.1) with ESMTP id l3IIYVui000930 for ; Wed, 18 Apr 2007 20:34:32 +0200 Subject: Re: [Qemu-devel] [PATCH] PPC termios structure ordering From: "J. Mayer" In-Reply-To: References: Content-Type: text/plain Date: Wed, 18 Apr 2007 20:34:35 +0200 Message-Id: <1176921275.6333.72.camel@rapid> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Tue, 2007-04-17 at 16:20 -0400, Stuart Anderson wrote: > Just found a small problem w/ the termios structure as defined for PPC > linux user. It doesn't match the one in include/asm-powerpc/termbits.h. > > Index: linux-user/ppc/termbits.h > =================================================================== > --- linux-user/ppc/termbits.h (revision 44) > +++ linux-user/ppc/termbits.h (working copy) > @@ -7,8 +7,8 @@ > unsigned int c_oflag; /* output mode flags */ > unsigned int c_cflag; /* control mode flags */ > unsigned int c_lflag; /* local mode flags */ > + unsigned char c_cc[TARGET_NCCS]; /* control > characters */ > unsigned char c_line; /* line discipline */ > - unsigned char c_cc[TARGET_NCCS]; /* control > characters */ > unsigned int c_ispeed; /* input speed */ > unsigned int c_ospeed; /* output speed */ > }; > > > With this change, both host and target 'stty -a' give the same output. Thanks. I'll take a better look to this patch then apply. There maybe the same issue in the ppc64 strucutre ? -- J. Mayer Never organized